Open Roger-luo opened 5 years ago
I think we now just need to define a generic function (but do not overload the svd
in LinearAlgebraand dispatch it to magma
gesdd` in this repo as the upper most interface.
NOTE: PyTorch is using gesdd
at the moment:
they basically just convert the cuda pointer back to CPU, feed it into magma gesdd and convert it back to cuda, I think we could just do the same thing for now. But as a binding package, we should provide the bindings anyway.
@vchuravy suggested we could have a gesdd implemented in Julia to avoid this during JuliaCon, which is also possible.
Yes one month ago I read their code for the gpu version of magma_gesdd in pytorch and followed but only did this stuff in the test file test/dense/svd.jl as we can see. I will open a new PR and push a dispatched src.
This is sort of resolved, but we will need some frontend wrapper later.