Roger92 / metric-ruler-labels

MIT License
5 stars 2 forks source link

Drag Ruler with hiding Foundry Measurments does not work #27

Closed Radulf321 closed 1 year ago

Radulf321 commented 1 year ago

Hi, I'm really glad to have found your module :) Thanks a lot for that. My German group will really enjoy to finally play in metric system! However, I found a small bug. I also use Drag Ruler and since I don't care about feet, I activated the option to hide the measurements of Foundry. Now, when I drag a character and the Drag Ruler is activated, the correct measurement (in meters, without feet) is shown for a short duration and then disappears. Once I disable the option to hide the measurements, everything works fine. I validated this bug and deactivated all other modules, except for Drag Ruler, your module, and their requirements. We play Pathfinder 2e, in case that is relevant. Foundry and all modules should be up to date:

If I can provide you with any more information, feel free to ask. Thank you for your effort!

Roger92 commented 1 year ago

Thx for the post... i will take a look somewhere during the next days :)

Roger92 commented 1 year ago

Oh yah you are right... i can reproduce that on my end :) I guess there will be a fix in the coming week :) Until then, just dont hide the foundry labels ;) ... And nice to hear that my module helps you.

Nicht Metrische Systeme sind eh für die Tonne :D

Roger92 commented 1 year ago

Found the culprit :) Will push a fix tomorrow.

Radulf321 commented 1 year ago

Wow, that's fast :) Thanks a lot! I did not expect to have the fix for our session tomorrow :)

Roger92 commented 1 year ago

Should be fine now :) ... The little flickering of the labels when moving is a known thing... But currently i cant get rid of them, given the way i overwrite the dragruler labels.

Roger92 commented 1 year ago

Does it work now? :) Or do you see still problems @Radulf321

Radulf321 commented 1 year ago

I only got to test it now. But it works great! Thank you for your fast handling!