RogerSelwyn / O365-HomeAssistant

Office 365 integration for Home Assistant
MIT License
203 stars 15 forks source link

Feature request: convert O365 Tasks sensor to 2023.11.x ToDo entity #174

Closed nathan-curtis closed 1 year ago

nathan-curtis commented 1 year ago

2023.11.x will introduce the ToDo entities

Yeah it just needs to happen. Google tasks and Todoist are being converted on launch

https://rc.home-assistant.io/blog/2023/10/25/release-202311/#there-is-a-lot-todo

RogerSelwyn commented 1 year ago

See this branch - https://github.com/RogerSelwyn/O365-HomeAssistant/tree/todo_entity

RogerSelwyn commented 1 year ago

Just to comment, the implementation of To-do as implemented by HA so far has a subset of functionality compared to that provided by O365. It has no concept of:

If you want to create tasks with these attributes, you will need to use the services provided by the integration rather than the To-do Lists panel.

nathan-curtis commented 1 year ago

Totally Understand. That's what we get with new features. I intend to put feature requests for ToDo to support for the missing parts if it's not already in progress. I strongly suspect Todoist needs it too, and Google Tasks should as well. I haven't played with the beta to see what additions it's getting in the update.

In any case the integration should support the built-in features else it's a discoverability issue at a minimum.

I would suggest of course not deprecating the old task sensors until there is feature parity on the builtin construct of course.

Maybe your code for the missing parts could even work the toto core to add the features...

RogerSelwyn commented 1 year ago

I have just moved all the data over to the ToDo as attributes as they were before, so people will see no change apart from the entity type change. I will of course identify it as a breaking change in the release notes at the right time.

I don’t want to maintain two sets of sensors and two sets of services.

SamBouwer commented 1 year ago

I've just installed the todo_entity branch and it works great with Microsoft To Do lists! Sync is crazy fast (near instant). Thank you for developing this!

@nathan-curtis could you link your FR's in the Home Assistant Issues list here?

nathan-curtis commented 1 year ago

Will do.

RogerSelwyn commented 1 year ago

I've just installed the todo_entity branch and it works great with Microsoft To Do lists! Sync is crazy fast (near instant). Thank you for developing this!

I think every 30 seconds πŸ˜‰ Or instant push, 30 second pull.

uSlackr commented 1 year ago

How do I install a beta branch?

\Greg


From: RogerSelwyn @.> Sent: Wednesday, November 1, 2023 4:05:07 PM To: RogerSelwyn/O365-HomeAssistant @.> Cc: Subscribed @.***> Subject: Re: [RogerSelwyn/O365-HomeAssistant] Feature request: convert O365 Tasks sensor to 2023.11.x ToDo entity (Issue #174)

I've just installed the todo_entity branch and it works great with Microsoft To Do lists! Sync is crazy fast (near instant). Thank you for developing this!

I think every 30 seconds πŸ˜‰

β€” Reply to this email directly, view it on GitHubhttps://github.com/RogerSelwyn/O365-HomeAssistant/issues/174#issuecomment-1789595110, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGEO6Z7CVEO5UMSBNZDZEMTYCKTPHAVCNFSM6AAAAAA6UK44P2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBZGU4TKMJRGA. You are receiving this because you are subscribed to this thread.Message ID: @.***>

RogerSelwyn commented 1 year ago

You need to download the repository and copy the relevant folder manually. Or I will probably create a beta release tomorrow. You will need 2023.11 for it to install.

SamBouwer commented 1 year ago

@uSlackr you can use git clone -b todo_entity https://github.com/RogerSelwyn/O365-HomeAssistant.git and then upload the contents of the downloaded \O365-HomeAssistant\custom_components\o365 folder into your Home Assistant \config\custom_components\o365 folder. Don't forget to restart Homa Assistant to trigger the "repair" to authenticate with your Office 365 account.

nathan-curtis commented 1 year ago

could you link your FR's in the Home Assistant Issues list here?

Which ones are you referring to specifically? I dont have anything else but this.

SamBouwer commented 1 year ago

@nathan-curtis the one you are referring to here:

I intend to put feature requests for ToDo to support for the missing parts

So you might not have created those yet ;)

nathan-curtis commented 1 year ago

Tracking now. Yeah may be a day or so have some things to get done first

RogerSelwyn commented 5 months ago

I'll probably tag a few posts, but I'm trying to get some views. I'm considering breaking up the monolithic O365 integration into smaller, more manageable items. If you have a view, please comment here:

O365 --> MS365 - A potential big change - your views needed