search

Rogier-5 / minetest-mapper-cpp

Generates maps of minetest and freeminer worlds
Other
9 stars 4 forks source link

Wip msvc compile #13

Closed adrido closed 8 years ago

adrido commented 8 years ago

Some other fixes for gen-build-config.bat

Rogier-5 commented 8 years ago

Thanks very much for all the testing / debugging.

I did some reordering and splitting/squashing of commits, to eliminate the unnecessary noise, and so that the changes will be easier for other people to make sense of. I also made a few documentation changes, and I removed a few redundant lines in one of the MSVC project files.

I think it would be useful to include some information (e.g. a link) in the documentation where somebody interested in compiling on windows might be able to download a suitable version of libdg. Could you give me link, so that I can include it in the docs; or could you include one yourself ?

If you're fine with the current state of the PR (including my rearrangements and squashes), and with the libdg download info included, then as far as I'm concerned, the PR will ready for merging.

adrido commented 8 years ago

Thanks very much for all the testing / debugging.

No problem. :-)

I did some reordering and splitting/squashing of commits, to eliminate the unnecessary noise, and so that the changes will be easier for other people to make sense of. I also made a few documentation changes, and I removed a few redundant lines in one of the MSVC project files.

Its Ok. If the project file is still working I think its ok.

I think it would be useful to include some information (e.g. a link) in the documentation where somebody interested in compiling on windows might be able to download a suitable version of libdg. Could you give me link, so that I can include it in the docs; or could you include one yourself ?

I can send you a zip file with the libgd.lib/.dll that is build with the same version of zlib as found in the nuget repo.

If you're fine with the current state of the PR (including my rearrangements and squashes), and with the libdg download info included, then as far as I'm concerned, the PR will ready for merging.

Ill check it again and give my OK in ~2-3 hours

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/Rogier-5/minetest-mapper-cpp/pull/13#issuecomment-221521378

Rogier-5 commented 8 years ago

I think it would be useful to include some information (e.g. a link) in the documentation where somebody interested in compiling on windows might be able to download a suitable version of libdg. Could you give me link, so that I can include it in the docs; or could you include one yourself ?

I can send you a zip file with the libgd.lib/.dll that is build with the same version of zlib as found in the nuget repo.

It's not primarily for my convenience as I can't compile on Windows anyway, but for other people who are reading the documentation and wish to compile using MSVC. They'll appreciate having a location to go to, instead of going through the hassle of searching the internet themselves.

I understood that you obtained the version of libgd somewhere from the internet ? Or did you compile it yourself ?

adrido commented 8 years ago

I had to compile it by myself, because it must use the same version of zlib as used by minetestmapper. But it was easy, because they provide a working cmakeList.txt. Also there are no "official" builds for windows.

adrido commented 8 years ago

Here are 2 packages of libgd. Both build on 25.05.2016 with Visual Studio 2015 (vc_140) They contain all files of gd required to build minetestmapper with Visual Studio. Tested with VS 2015. Version is 2.2.1 (even if package-name tells something different :laughing: ) Source code can be found here. libgd-2.1.0-win32.zip libgd-2.1.0-win64.zip

@Rogier-5 I think its ready now. except you may have to note something about x64 build: x64 build might fail due a bug of snappy (required for leveldb). Solution: open packages\Snappy.1.1.1.7\lib\native\src\snappy.cc and change line 955 from #ifndef WIN32 to #ifndef _WIN32

Rogier-5 commented 8 years ago

Here are 2 packages of libgd. Both build on 25.05.2016 with Visual Studio 2015 (vc_140) They contain all files of gd required to build minetestmapper with Visual Studio. Tested with VS 2015. Version is 2.2.1 (even if package-name tells something different :laughing: ) Source code can be found here. libgd-2.1.0-win32.zip libgd-2.1.0-win64.zip

Thanks. I'll make them available for download, for people who want to avoid recompiling gd.

@Rogier-5 I think its ready now. except you may have to note something about x64 build: x64 build might fail due a bug of snappy (required for leveldb). Solution: open packages\Snappy.1.1.1.7\lib\native\src\snappy.cc and change line 955 from #ifndef WIN32 to #ifndef _WIN32

I'll add it to the manual.