search

Rogier-5 / minetest-mapper-cpp

Generates maps of minetest and freeminer worlds
Other
9 stars 4 forks source link

Fix --prescan-world=disabled-force does not work #14

Closed adrido closed 8 years ago

adrido commented 8 years ago

This would make --disable-blocklist-prefetch=force and --prescan-world=disabled-force work again.

Also fixes a compiler warning on MSVC.

Rogier-5 commented 8 years ago

Wonder why gcc and clang do not complain about this. Assigning a constant value of 2 to a bool makes anyone wonder whether that was really intended...

adrido commented 8 years ago

That's an relay odd behaviour. :confused: I get much more warnings about some conversation issues on MSVC, I thought you already knew about that... If you want I can solve them and create antother pull request.

Rogier-5 commented 8 years ago

I thought you already knew about that...

No. Using both gcc and clang, minetestmapper compiles without warnings. (I just verified it to be sure, on Debian Linux 32 and 64 bit, with clang and gcc, and the most recent software installed. I had to fix one new warning for gcc 5 :-)

If you want I can solve them and create antother pull request.

Please do. I think that as much as practical, software should compile without warnings. When compiling, they distract from messages that are important...

(that means that, depending on circumstances, I might prefer to disable some warnings instead of changing the software: if the code is correct, and eliminating the warnings makes it less readable and therefore less understandable...)