RogoShum / BruteForceRenderingCulling

Minecraft optimization mod
GNU Lesser General Public License v3.0
16 stars 0 forks source link

[1.20.1 | Forge 47.3.3] Mod crashes on render distance downscaling #23

Open FLORIAN4600 opened 3 months ago

FLORIAN4600 commented 3 months ago

I'm using a heavily modded client (~120 loaded mods && ~80 mod files)

My forge version: 1.20.1-47.3.3 My main client mods: Embeddium, Embeddium++, Fastload, ImmediatelyFast, ModernFix, CullLessLeavesReforged, Saturn, FerriteCore My main common mods: Create (and multiple addons), ImmersiveAircraft, ImmersiveEngineering

Problem: java.lang.IllegalStateException: Buffer mapping is already disposed

Crash report Log File

DeshiDesu commented 3 months ago

I also have this issue. If you load too many chunks in a short period, you will get the crash "buffer mapping is already disposed"

FLORIAN4600 commented 3 months ago

I might have my own idea about what is going wrong for it to dispose lf the chunk map buffer twice Maybe related to minecraft event firing twice because of, well... Events (they always act bizarre with Minecraft) or because of lag Or it might be something else I'll try debugging the source code to find it out and do a pull request later if I do find the cause, because I am not sur if the mod author is quick or not to resolve github issue posts (The idea I actually get is either a shared buffer cleans twice, or l.559 of the culling state manager, the cleanup fires twice on the same object, since it only checks for null objects and not already cleaned objects (+ it could run at the same time making the check first and then making the check non valid only after both fired functions have passed)

This is a long message explaining what I think might be the problem, for the author to see in case I cannot free enough time to debug the mod's code

FLORIAN4600 commented 3 months ago

Oups, I pushed the wrong button and closed it by accident

Sazuzaki commented 2 months ago

Can confirm, this issue is bugging me as well. Seems to happen when I load too many chunks

Sazuzaki commented 2 months ago

Can be fixed by disabling Async Rebuild Chunk, but at a cost of frames.

admiralredshirtdev commented 2 months ago

I'm having the same issues, however my situation is similar yet different (I'm running a 350 mod fabric modpack) and I'm having the same causes for crashing like op's post ie changing render distance, just even loading the world for more than 5min crashes it giving the same buffer mapping is already disposed error I'm trying the disabiling async rebuild chunk option however my situation is different from op's and will reply if it helps with my issues, uploading my crashreport in hopes of helping crash-2024-09-08_14.45.17-client.txt