RogueEdit / pyRogue

Educational Project
GNU Affero General Public License v3.0
51 stars 37 forks source link

Error when Submitting Changes #144

Closed jemajet closed 2 months ago

jemajet commented 2 months ago

When submitting changes (option 26), there is an error where the color for the formatter isn't set.

Command: 26
Traceback (most recent call last):
  File "/Users/jemajet/Repos/pokerogue-repos/onlineRogueEditor/src/main.py", line 247, in <module>
    main()
  File "/Users/jemajet/Repos/pokerogue-repos/onlineRogueEditor/src/main.py", line 233, in main
    func()  # Call the associated function
    ^^^^^^
  File "/Users/jemajet/Repos/pokerogue-repos/onlineRogueEditor/src/modules/mainLogic.py", line 680, in update_all
    cFormatter.print("That seemed to work! Refresh without cache (STRG+F5)")
TypeError: cFormatter.print() missing 1 required positional argument: 'text'

The change would be simple in line 680 of src/mainLogic.py. I tried to make a pull request but I think the permissions are set so only you can contribute so I wanted to bring it your attention. The change is just:

cFormatter.print(Color.GREEN, "That seemed to work! Refresh without cache (STRG+F5)")
JulianStiebler commented 2 months ago

Oh you should be able to PR tho, atleast i didnt touched stuff there. Other than that thanks to make me aware <3

Atleast we have @mour0 who contributed once, so it has atlest worked in the past

JulianStiebler commented 2 months ago

I actually cant believe i didnt made the color optional... Changig it now seems dumb tho .'D Fixed vor 0.3.1 which is pending alrdy

jemajet commented 2 months ago

No worries I think I was being dumb so I would be able to make PR's here I just forgot to fork.