search

RogueEdit / pyRogue

Educational Project
GNU Affero General Public License v3.0
51 stars 37 forks source link

Bug: unlock all starter and unlock all (non passive/egg mons) #172

Closed sacreddo closed 1 month ago

sacreddo commented 1 month ago

not sure if is just me but could you check this one:

if i edit my trainer.json that im getting from server (doesnt matter if its online or offline its always the same on any trainer.json) and use the unlock all starter (12) or unlock all (14) from the tool following happens:

he also edits all starters that dont have passive ability and egg moves and ads them a value so that if you save and upload your trainer.json and use it online/offline and choose one of the no passive/egg moves pokemon and want to start a new game the game just freezes.

here attached some screenshots for reference:

1

2

3

4

5

JulianStiebler commented 1 month ago

Oh yeah for that was the nonPassive.json, forgot to include it in the rewrite. Already wondered why peekachu was broken :'D

JulianStiebler commented 1 month ago

Yeah i somehow have type problems since the rewrite :'D I before compared entry as int within the enum which holds strings.. All other hold int :'D Well, its fixed in a second.

sacreddo commented 1 month ago

happens :) i have some experience and was able to fix it manually myself but at least it is now being fixed for everyone thanks for your work and providing this editor so we dont have to grind in pokerogue for the rest of our life :p

JulianStiebler commented 1 month ago

Pushed the fix, found multiple other typeErrors and another bug in editStarters 🗡️

Hehe yeah happens too often 🔢 But i remember we alwys had each input wrapped in int(), now i obviously either have to still put the input as int, or the value, but did neither in most places :D

Well i probably got catched by me naming it getIntegerInput, which implied its an integer, getRangeInput would be more fitting in this case..^^