RogueEdit / pyRogue

Educational Project
GNU Affero General Public License v3.0
51 stars 37 forks source link

Bug: Need attention immediately #182

Closed oMagoSupremo closed 1 month ago

oMagoSupremo commented 1 month ago

What Operating System are you on - Windows, Ubuntu, Mac, ...

Describe the bug - A clear and concise description of what the bug is.

To Reproduce - Describe the steps needed to reproduce the bug.

Screenshots - If applicable, add screenshots to help explain your problem. https://prnt.sc/9usR9kljtYTZ

JulianStiebler commented 1 month ago

You need to have a normal session saved. Like just start a session on slot1, kill 1 pokemon, save and quit. Theres also features to edit the party with G-Max and stuff. Logically if you dont have any save slot existing, it can't fetch one. You was asked at the start "Which slot" ranging from 1-5. If you do the step named above it will be able to fetch a slot and update normally without problem.

This is due the save endpoint, it wants data combined (slot/session + trainer), it's also more efficient to save both at once rather than calling twice.

But i get what you mean; theoretically you don't edit any session related stuff, but trainer general's and you assumed you don't need a slot.

Though, it was a good reminder, i really need to make some errors more interactive, log more - not close on saving when a error in a part happened etc.

Edit: I always missclick "close and comment" 🗡️ When you have read please close it :)