RogueEdit / pyRogue

Educational Project
GNU Affero General Public License v3.0
51 stars 37 forks source link

Bug: Need attention immediately #184

Closed oMagoSupremo closed 1 month ago

oMagoSupremo commented 1 month ago

What Operating System are you on - Windows, Ubuntu, Mac, ...

Describe the bug - A clear and concise description of what the bug is.

To Reproduce - Describe the steps needed to reproduce the bug.

Expected behavior A clear and concise description of what you expected to happen.

JulianStiebler commented 1 month ago

Yeah i know its not quite working as expected in that matter - atleast the egg generation is accurate to its chosen type and such, Its probably missing a valid source type, otherwise according to source this should work as is - but then also, it's not much extra to just edit the starter to be shiny afterwards anyhow and i didnt came around looking at it (yet) - closing for now but i have a eye on it :)

sourceType?: EggSourceType;
  /** Needs to be defined if eggOption pulled is defined or if no species or isShiny is degined since this will be needed to generate them. */
        export enum EggSourceType {
            GACHA_MOVE,
            GACHA_LEGENDARY,
            GACHA_SHINY,
            SAME_SPECIES_EGG,
            EVENT
        }
  scene?: BattleScene;
  /** Sets the tier of the egg. Only species of this tier can be hatched from this egg.
   * Tier will be overriden if species eggOption is set.
   */
  tier?: EggTier;
  /** Sets how many waves it will take till this egg hatches. */
  hatchWaves?: number;
  /** Sets the exact species that will hatch from this egg.
   * Needs scene eggOption if not provided.
   */
  species?: Species;
  /** Defines if the hatched pokemon will be a shiny. */
  isShiny?: boolean;
  /** Defines the variant of the pokemon that will hatch from this egg. If no variantTier is given the normal variant rates will apply. */

I tryed with sourceType and such but it never hatches shiny, despite the description clearly applied correctly.