RogueMaster / flipperzero-firmware-wPlugins

RogueMaster Flipper Zero Firmware
https://www.patreon.com/RogueMaster
GNU General Public License v3.0
5.28k stars 540 forks source link

Settings - Desktop - Favorite Apps issue #476

Closed bip3r closed 1 year ago

bip3r commented 1 year ago

Describe the bug.

HI there.. I found some issues with the latest Flipper firmware..

In the ReadMe.md of flipperzero-firmware-wPlugins repository in the section "All Changes/Features" it says:

Settings: Updated HOLD UP to go to Primary Favorite [(By RogueMaster)] Settings: Updated HOLD DOWN to go to Secondary Favorite [(By RogueMaster)]

but what I found is that within the menu: Settings -> Desktop -> Primary Favorite App when you enter it, above it says "Secondary favorite app:"

and the same in Settings -> Desktop -> Secondary Favorite App when you enter it, above it says "Primary favorite app:"

When I try to set the Primary Favorite App (HOLD UP), it sets the Secondary (for HOLD DOWN) And opposit with the other menu.

Moreover, after one change of the fav app, I'm not able to set any of the availible apps. Only Sub-GHz, NFC and 125kHz work, while with e.g. Infrared, HOLD UP/DOWN does nothing.

Anyway, that firmware is just fabulous! Thx ofr a great job.

Reproduction

Enter Settings -> Desktop -> Primary/Secondary Favorite App

Target

latest Flipper RM firmware

Logs

No response

Anything else?

No response

RogueMaster commented 1 year ago

For any apps that are available in FAP form under Applications => Main, they should be set there instead of from main menu. Will check your findings to see if something can be fixed with the SWAP on the settings set.

bip3r commented 1 year ago

Thx! Indeed this way (Applications => Main) it works. So the only minor issue is the swap of Primary/Secondary Fav App menu.

RogueMaster commented 1 year ago

The settings are fixed. The issue is still there kind of. But up is Primary and down is Secondary on latest release.