RohanAlexander / telling_stories

Telling Stories with Data
https://rohanalexander.github.io/telling_stories/
115 stars 77 forks source link

Chapter 7 Notes #12

Closed anniecollins closed 2 years ago

anniecollins commented 2 years ago
RohanAlexander commented 2 years ago
  • Formatting for links was inconsistent in this chapter. I changed them all to be hyperlinked words instead of just inline link text.

Thank you for making that consistent.

  • “Making a website” section: I took some liberties with the intro here, I felt like the flow was kind of awkward in places

Your changes are great. Thank you.

  • “Quatro” section: what is your motivation for including Quatro websites? Just because they’re built in? This section feels a bit too sparse and lacking motivation as is. Some suggestions:

    • Move this section to be the first type of website explained and then add in some comment like “this is easy because it’s built in but there are much better ways to make a website”
    • Explain more about what a Quatro website is good for compared with the other types of websites
    • Delete section

Yeah, I want to include them because they're built in and because I think they're going to try to replace Distill with this. I guess it's sparse because I've not really used them thoroughly myself. I'll pick your second option for now.

  • “Distill” section: I think it would be worth differentiating between Distill websites and Distill blogs in this section, since you use the terms blog and website interchangeably within this section. If your goal is to emphasize that you can use Distill to create a blog, it would also be worth mentioning the file structure that comes along with blogs (distinguishing between pages in the navbar and posts in the ‘_posts’ folder).

Have tried to distinguish, but it's still not great.

  • “Blogdown” section: Include image of basic Apéro site

Good idea, it ended abruptly. Have added.

  • Line 288: I think the last sentence of this paragraph is (starting with “Once we have that token we add it to our R environment” is incomplete)

Thanks. Have updated.

  • Line 234/Figure 7.15: spend_construction values are in 1000's of USD. Update legend or units

Lol. Great pick up - data seem a lot more reasonable now.

  • Figure 7.16: the dark theme with purple points is a bit hard to see

Okay. Have changed it to 'light'.

  • Line 357: What do you mean by “boys names tend to be more clustered”? It looks to me like girls names are more clustered and boys names are more spread out

It made sense at the time, but I'm confused by the graph now. For now I'm just removing the sentence.

  • Figure 7.18: can you embed this shiny app in the book instead of including an image?

Yes, great idea. Will do that once everything is finalized.

  • Exercise 1/2: These don’t seem particularly related to the content of the chapter? Perhaps there’s a way to incorporate an interactive data viz exercise with the simulated data, or move these exercise to a more relevant section?

I wanted to add these types of exercises to all the chapters because of how important these skills are. But I've distinguished them now so that's obvious. And have added an interactive aspect to it.