search

RohanNagar / jmail

A modern and lightweight library for working with email addresses in Java
https://www.rohannagar.com/jmail
MIT License
131 stars 6 forks source link

Add option for lowerCase when normalizing #245

Closed Sprokof closed 4 months ago

Sprokof commented 4 months ago

Hi, i improved email normalization by adding lower case option, it's related to 171 issue

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.99%. Comparing base (7c380c8) to head (cda1813). Report is 45 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #245 +/- ## ============================================ + Coverage 97.95% 97.99% +0.04% - Complexity 361 367 +6 ============================================ Files 13 13 Lines 636 649 +13 Branches 174 175 +1 ============================================ + Hits 623 636 +13 Partials 13 13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RohanNagar commented 4 months ago

Hi @Sprokof, thank you so much for the contribution!

This looks great overall to me. I am wondering if we can default the option to false for now? That way the feature can be released without causing any breaking changes. I would then change the default to true when v2.0 is ready.

Sprokof commented 4 months ago

Yes, we can set param to false by default

Sprokof commented 4 months ago

Can you explain why snyk bring this error? I must configure something?

RohanNagar commented 4 months ago

Thanks for updating the default! I don't know what is going on with the snyk check, but don't worry about it. Your code looks great to me. I'm going to go ahead and merge this.

Thanks again for the contribution, it is really appreciated!