RohitKushvaha01 / Xed-Editor

Advanced Text Editor for android
MIT License
234 stars 13 forks source link

TODO #110

Open RohitKushvaha01 opened 2 weeks ago

RohitKushvaha01 commented 2 weeks ago
hasanelfalakiy commented 2 weeks ago

add option refresh in preview html/markdown when file change from other app

AndroMaster436 commented 1 week ago

And since the terminal is being improved, it is necessary to add settings to it such as: font size, keep in background, etc.

AndroMaster436 commented 1 week ago

And btw, you can't access the /sdcard folder from the terminal

AndroMaster436 commented 1 week ago

@RohitKushvaha01 Why did you remove sftp/ftp support from the list?

RohitKushvaha01 commented 1 week ago

@RohitKushvaha01 Why did you remove sftp/ftp support from the list?

It already has a issue

AndroMaster436 commented 1 week ago

https://github.com/user-attachments/assets/ce91ae75-f008-44d5-9d54-f25bc6ef95be

There is also a bug when entering text. In a normal editor, if the cursor is inside " " or ( ), then if when entering ) or " at the end, then it should not print it again, but simply through it!

AndroMaster436 commented 1 week ago

Screenshot_20240907-091609~3

There is an idea about git integration. If the project has a .git folder and it is not empty, then the git push button should appear here. When you click it, you will be asked for the commit name and branch, and after that the console with the script will start:

git add .
git commit -m "<name>"
git push origin <branch>

Moreover, this script can be edited in the settings in new page "Git"

On the page itself, you can set up login details (name and token), install Git itself in Alpine, etc.

atlantis451 commented 1 week ago

Add

AndroMaster436 commented 1 week ago

@RohitKushvaha01 work in progress... Screenshot_20240908-091339

AndroMaster436 commented 1 week ago

I can't add button to the top panel on an equal footing with the save button, etc.

RohitKushvaha01 commented 1 week ago

I can't add button to the top panel on an equal footing with the save button, etc.

Use "ifRoom" instead of "always" otherwise it may cause rendering issues on small screen devices

AndroMaster436 commented 1 week ago

I can't add button to the top panel on an equal footing with the save button, etc.

Use "ifRoom" instead of "always" otherwise it may cause rendering issues on small screen devices

I tried it, and as a result - the button does not appear. I set it back to "always" and it appeared again.

hasanelfalakiy commented 1 week ago

oh okay thanks

AndroMaster436 commented 1 week ago

@RohitKushvaha01 I have now found a bug in the code that does not allow working with the editor with the option keepDrawerLocked

Screenshot_20240909-131928~2

My solution: move the loading popup hiding from keepDrawerLocked to the After(100) After(400) code

Fixed code:

After(100) {
                    rkUtils.runOnUiThread {
                        it.newEditor(file)
                        it.adapter?.onNewEditor()
                    }

                    //delay close drawer after 400ms
                    After(400) {
                        if (!SettingsData.getBoolean(Keys.KEEP_DRAWER_LOCKED, false)) {
                            rkUtils.runOnUiThread {
                                it.binding.drawerLayout.close()
                            }
                        }
                        loading.hide()
                    }
                }
hasanelfalakiy commented 6 days ago

@RohitKushvaha01 I have now found a bug in the code that does not allow working with the editor with the option keepDrawerLocked

Screenshot_20240909-131928~2

My solution: move the loading popup hiding from keepDrawerLocked to the After(100) After(400) code

Fixed code:

After(100) {
                    rkUtils.runOnUiThread {
                        it.newEditor(file)
                        it.adapter?.onNewEditor()
                    }

                    //delay close drawer after 400ms
                    After(400) {
                        if (!SettingsData.getBoolean(Keys.KEEP_DRAWER_LOCKED, false)) {
                            rkUtils.runOnUiThread {
                                it.binding.drawerLayout.close()
                            }
                        }
                        loading.hide()
                    }
                }

What is keepDrawerLocked for?

RohitKushvaha01 commented 6 days ago

What is keepDrawerLocked for?

It keeps drawer opened when opening a file

hasanelfalakiy commented 6 days ago

What is keepDrawerLocked for?

It keeps drawer opened when opening a file

okay 👍

hasanelfalakiy commented 6 days ago

What is keepDrawerLocked for?

It keeps drawer opened when opening a file

what about this bug, do i need to open an issue? sometimes it can be zoomed sometimes it can't Screenshot_20240909_185833

RohitKushvaha01 commented 6 days ago

What is keepDrawerLocked for?

It keeps drawer opened when opening a file

what about this bug, do i need to open an issue? sometimes it can be zoomed sometimes it can't Screenshot_20240909_185833

Open a issue

RohitKushvaha01 commented 5 days ago

@RohitKushvaha01 I suggest to rewrite git integration from JGit to KGit

I am currently rewriting main activity with viewpager2

AndroMaster436 commented 5 days ago

@RohitKushvaha01 I suggest to rewrite git integration from JGit to KGit

I am currently rewriting main activity with viewpager2

Sorry, I just checked the kgit code. It's just a wrapper over jgit.

hasanelfalakiy commented 5 days ago

is jgit used to create gui apps from git like this? https://github.com/tiagocasemiro/Source

RohitKushvaha01 commented 5 days ago

is jgit used to create gui apps from git like this? https://github.com/tiagocasemiro/Source

Yes

hasanelfalakiy commented 5 days ago

is jgit used to create gui apps from git like this? https://github.com/tiagocasemiro/Source

Yes

if that was added it would be cool, this is also the same https://github.com/JetpackDuba/Gitnuro

AndroMaster436 commented 5 days ago

@RohitKushvaha01 After refactoring the main activity, extra keys disappeared and the accent color basically only affects the settings screen

AndroMaster436 commented 5 days ago

Also projects are not saved anymore :(

AndroMaster436 commented 5 days ago

Also my git improvements disappeared:(

AndroMaster436 commented 5 days ago

Screenshot_20240911-094443 So you haven't finished it yet?

RohitKushvaha01 commented 5 days ago

Screenshot_20240911-094443 So you haven't finished it yet?

its not finished most of features probably not work

AndroMaster436 commented 5 days ago

Screenshot_20240911-094443 So you haven't finished it yet?

its not finished most of features probably not work

And btw, you will return those improvements to the git that I made yesterday, right?

RohitKushvaha01 commented 5 days ago

Screenshot_20240911-094443 So you haven't finished it yet?

its not finished most of features probably not work

And btw, you will return those improvements to the git that I made yesterday, right?

Probably

AndroMaster436 commented 5 days ago
  1. No animation when swtich tab
  2. New tab does not opening automatically and need to open manually
  3. When first launch app - no syntax highlighting and editor theme is light (In settings installed black theme)

Bugs which I found

AndroMaster436 commented 5 days ago

Among the innovations, there is an animation of switching to the previous tab when closing a tab

AndroMaster436 commented 4 days ago

Another bug found, you can open the same file multiple times

AndroMaster436 commented 4 days ago

Another bug found, you can open the same file multiple times

And autosave is not working