search

Rohland / htmldiff.net

Html Diff algorithm for .NET
MIT License
288 stars 83 forks source link

Bugfix/issue20 missing closing tag #61

Closed PhilippRiegelmann closed 3 days ago

PhilippRiegelmann commented 2 weeks ago

I noticed an error when inserting an additional word at the end of a newly formatted text. A </ins>was inserted after the new word, but another closing tag for the opened <ins class='mod'> was missing. In my opinion, this corresponds to the problem described in Issue 20. I have added the problem described there as well as other edge cases that I consider relevant as additional test cases.

PhilippRiegelmann commented 5 days ago

Hello @Rohland, we are currently using your package in one of our software projects and encountered an issue that I would like to fix with this pull request. Is there a chance that the PR could be reviewed soon? Alternatively, we would initially provide a package from our forked repository so that we can continue working in our software project.

Rohland commented 5 days ago

Hi @PhilippRiegelmann - sorry for the delay, will try and take a look in the next day or two.

Rohland commented 3 days ago

Thanks @PhilippRiegelmann for the changes 👍. It's been a while since I've worked on this library, so took a minute to get around to this. This is closed by #62 - version 1.5.0 should be available on nuget (if not, shortly after indexing).