Rohzek / SimpleOreGeneration

Simple Ore Generation Mod
5 stars 2 forks source link

[4.3.2] Simple Ore Gen overrides ore gen for other mods, even when disabled in config #31

Open rgtexa opened 6 years ago

rgtexa commented 6 years ago

Unclear if this is a bug or intended behavior.

Expected behavior: disabling an entry in OreGen.json allows generation by other mods (for example, disabling SOG copper should allow Mekanism's copper to spawn if installed and enabled in it's config).

Actual behavior: disabling an entry in OreGen.json causes all generation to be disabled, even if enabled in the providing mod (for example, Certus Quartz and Charged Certus Quartz ore provided by AE2 and enabled in AE2's config).

I only came across this because I know that previously SOG provided it's own Certus and Charged Certus ores, but they were removed (I believe in 4.2.1, but I cannot find any version history to verify). At that time, I configured my pack to use AE2's oregen and set the entries for surface Certus and Charged Certus in OreGen.json to disable = true and this seemed to work fine; I got AE2 ores spawning as expected.

However in the most recent version (4.3.2), it appears that disable = true also disables worldgen for those ores even when enabled in the other mod {i.e. AE2 or Mekanism). I verified this with both AE2's Certus and Charged Certus ores, as well as Mekanism's copper ore using a freshly generated world between config changes and using World Stripper to see the ore distribution in game.

If this is intended behavior, it should probably be noted in the documentation or config file.

Minecraft 1.12.2 SimpleOreGen 4.3.2 Forge 14.23.4.2739

Rohzek commented 6 years ago

Intended behavior for OreGen.json is to dictate rather or not SimpleOreGen does anything with the ores it generates. Disabling them, doesn't disable the override. To have the original mod spawn it's ores the compatibility boolean in options.cfg should be false. e.g. the entry:

Support for Applied Energestics 2 quartz

B:supportAppliedEnergestics2=false would set SimpleOreGen to not even be aware that AE2, or Certus Quartz exists. I'll definitely add a note to the documentation to clarify that. If that isn't working correctly, then that's a major bug I'll have to look into.