search

Roibal / Cryptocurrency-Trading-Bots-Python-Beginner-Advance

Crypto Trading Bots in Python - Triangular Arbitrage, Beginner & Advanced Cryptocurrency Trading Bots Written in Python
https://www.youtube.com/channel/UCVTnyT4fUxYkvawbggo8-AQ
MIT License
1.26k stars 433 forks source link

Filter failure: PRICE_FILTER #2

Closed GO1984 closed 5 years ago

GO1984 commented 5 years ago

While executing (Ubuntu 18.04 VM) Private_TriArbBot.py i get:

raise BinanceAPIException(response) binance.exceptions.BinanceAPIException: APIError(code=-1013): Filter failure: PRICE_FILTER

It seems, that the currencies are mixed up and the price is ist not correct. The bot want to buy BNBBTC @ 640.984552 insted of 0.00158 as of today 640.984552 is the price of ETH/USDT

Does anyone else have this problem?

Roibal commented 5 years ago

hello GO, yes I believe I have this part in error, and was dividing 1/price instead of price (which is why they are opposite, etc). I believe I have this fixed on a new version, I thought this version had the updated price.

GO1984 commented 5 years ago

Thank you. I look all day for the error, but can't find it. Any chance you point me to the right line in the code to change?

Roibal commented 5 years ago

Line ~324.

I just looked and I have uploaded newest version of tri arb bot--includes paper trading and output to social media.

Roibal commented 5 years ago

check out triarbbot_paper_and_tweet.py

GO1984 commented 5 years ago

Thank you for sharing you work. I will report, if everything works well...

Roibal commented 5 years ago

it may be better if you report if everything doesn't work well, ha ha!

GO1984 commented 5 years ago

Just to give an info. I have given up. I got lots of errors such as min_notional errors from the exchange and others. Nevertheless thank you for sharing. Your code gave me lots of ideas how to program in python.

Roibal commented 5 years ago

Yes, the Min_Notional comes direct from Binance, and requires a certain order volume, value, etc. Previously, Binance required all Binance Coins to be bought/sold in whole binance coins--you can imagine the headache this has caused! Luckily, they dropped this requirement, but it made tri arb very difficult in simply placing the orders because you had to determine the proper exchange rate to buy the binance coins, and if it changed then you were no longer purchasing 'whole' coins. This project started out pretty straightforwarded and then I started running into LOTS of unforeseen problems--like having to buy coins with whole binance coins!!