search

Roibal / Cryptocurrency-Trading-Bots-Python-Beginner-Advance

Crypto Trading Bots in Python - Triangular Arbitrage, Beginner & Advanced Cryptocurrency Trading Bots Written in Python
https://www.youtube.com/channel/UCVTnyT4fUxYkvawbggo8-AQ
MIT License
1.26k stars 433 forks source link

Fee Percentage Wrong #29

Open snub-fighter opened 5 years ago

snub-fighter commented 5 years ago

Regarding TriArb TriArbTrader

The fee calculation is incorrect it appears.

line 573 ---- fee_percentage = 0.13 #divided by 100 pseudo -> fee_percentage = 10%3 = 30% Shouldn't the fee percentage be 0.001 3 not 0.1 3 ?

Roibal commented 5 years ago

Hello - I believe when fee percentage is used, it is either divided by 100 or it compares to a value with a similar order of magnitude.

Roibal commented 5 years ago

on line 691, you can see that the calculated fees are multiplied times 100, converting them into percentage. So fee percentage is in percentage,

line 573 ----- fee_percentage = 0.1%*3

Roibal commented 5 years ago

Also the fee percentage will be different if you pay with Binance coin as well.