RoinujNosde / SimpleClans

Full featured Clan system for Minecraft
https://www.spigotmc.org/resources/simpleclans.71242/
GNU General Public License v3.0
50 stars 36 forks source link

Better Control Over Clan Member Count Limits #421

Closed Amirali1059 closed 7 months ago

Amirali1059 commented 8 months ago

Is your feature request related to a problem? Please describe. I wanted to configure some smart clan member count limits but realized the plugin only supports a constant number for clan member limits after searching through the documentation.

Describe the solution you'd like It would be nice to have a feature where a permission could be used to set clan member limits when given to the clan leader.

Describe alternatives you've considered If the above idea is not considered, it would be useful to have the ability to set different member count limits for verified clans versus unverified clans.

Additional context Having this feature could encourage clan leaders to verify their clans to gain the ability to invite more players to their clan.

Nishikiyama commented 8 months ago

Personally, I think it's a great idea

However I do think letting clan leaders set their own member limits is kind of on the verge of conventional or inconventional.

RoinujNosde commented 8 months ago

Possible duplicate of #208

Nishikiyama commented 8 months ago

Possible duplicate of #208

Half-dupe Changing members via config for two different clan member values (Verified / Non-verified...) versus Changing clan member limit via unlockables

Personally, I think not a dupe, since both can be made, for example non-verified clans get x amount of max members , verified could be first upgrade for all upgrades to come, and verifying clan opens up in-game purchase menu which after that you could buy more members

Amirali1059 commented 8 months ago

However I do think letting clan leaders set their own member limits is kind of on the verge of conventional or inconventional.

Thank you for your time!

I was thinking of the permission feature more like an admin option, so you can change how many members can be in someone's clan based on their play time on the server, or their rank, or based on how much money they have in their clan bank.

Nishikiyama commented 8 months ago

so you can change how many members can be in someone's clan based on their play time on the server, or their rank, or based on how much money they have in their clan bank.

So more like a command then instead of automation?

Amirali1059 commented 8 months ago

so you can change how many members can be in someone's clan based on their play time on the server, or their rank, or based on how much money they have in their clan bank.

So more like a command then instead of automation?

Kind of, #422 is fine, thank you for considering it! sorry for no reply in a long time.

Nishikiyama commented 8 months ago

so you can change how many members can be in someone's clan based on their play time on the server, or their rank, or based on how much money they have in their clan bank.

So more like a command then instead of automation?

Kind of, #422 is fine, thank you for considering it! sorry for no reply in a long time.

I think the way I made it is just fine, of course a more advanced version of it can be made but I believe for now that is quite enough :)

Of course I'm open to suggestions?

Amirali1059 commented 7 months ago

Thank you for your time, I think I close the issue as the feature is implemented now.