search

Rokoko / rokoko-studio-live-unreal-engine

GNU Lesser General Public License v3.0
45 stars 15 forks source link

Fix linux compilation and deprecations #71

Closed vaslabs closed 5 days ago

vaslabs commented 2 weeks ago

Hello, This PR fixes a few compilation issues on Linux and a few deprecation warnings (I assume for every platform)

Compilation error

UnrealEngine-5.4.4/Engine/Plugins/Smartsuit/Source/Smartsuit/Public/RokokoSkeletonData.h:196:5: error: field 'transform' will be initialized after field 'position' [-Werror,-Wreorder-ctor]
                , transform(Transform)
                  ^~~~~~~~~~~~~~~~~~~~
                  position(Position)

Deprecation API usage (instance example)

Engine/Plugins/Smartsuit/Source/Smartsuit/Private/VirtualProductionSource.cpp:1625:62: warning: 'GetArrayField' is deprecated: Passing an ANSI string to GetArrayField has been deprecated outside of UTF-8 mode. Please use the overload that takes a TCHAR string. Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile. [-Wdeprecated-declarations]
                                        TArray<TSharedPtr<FJsonValue>> NewtonsArray = SceneObj->GetArrayField("newtons");
vaslabs commented 2 weeks ago

Looks good, @vaslabs I see you added some more changes. Please let me know when you believe the PR is ready to be merged

Thanks, I've noticed today that more deprecations are reported when I build UE5 as I'm investigating some unrelated crashes, give me a few days and I'll let you know

arnirokoko commented 1 week ago

@vaslabs have you had the time to make progress on this PR? While adding mac support for the plugin I ran into the same compilation errors (see https://github.com/Rokoko/rokoko-studio-live-unreal-engine/pull/72)

vaslabs commented 1 week ago

@arnirokoko feel free to merge, we are gonna be doing some scenes over the weekend , if there are any issues I'll follow up. So far, it's running for us without issues