search

Rokuazery / LoL-Assist

League of Legends Automatic Runes & Spells
https://github.com/Rokuazery/LoL-Assist/
GNU General Public License v3.0
54 stars 1 forks source link

Don't replace existing runes and take just one #4

Closed owlnai closed 2 years ago

owlnai commented 2 years ago

Hey there, amazing app! There's one thing I would like to request. I had a few rune pages that I manually set before downloading LoL-Assist, but it seems the tool uses a new rune page every time you change your champion and they disappeared, so you could end up with multiple rune pages taken at the same lobby.

It would be nice if it could track the current rune page and change that one instead of taking the others. image

Rokuazery commented 2 years ago

Thank you for your suggestion, I'll try to implement your request in the future update.

Rokuazery commented 2 years ago

After investigating this issue, it seems like it was already "tracking" the current Rune Page. It creates a new Rune Page if there's no editable slot found. And it replaced an editable Rune Page if it's at the maximum limit for creating a new Rune Page. Unfortunately, I can't replicate this issue you're having. It might be because you have more than 2 editable Rune Pages, but I'm not sure if that's the case. I'll close this issue temporarily for now, sorry. BeforeAfter

owlnai commented 2 years ago

Oops, you're right! It seems it was an odd issue with the League of Legends UI, because I restarted the client and my old rune pages are now back and there's just one Lol-Assist page 😅