search

Rolamix / cordova-plugin-playlist

🎶 A Cordova plugin for Android and iOS with native support for audio playlists, background support, and lock screen controls 🎶
MIT License
33 stars 33 forks source link

Why is the volume so small?there would be a lot of noise when set volume=100 #16

Closed 442623641 closed 5 years ago

442623641 commented 6 years ago

the volume is too small， just like calling without opening the external sound. A lot of noise when set volume=100, it's there that can be controlled by setting?

robinbanbury commented 6 years ago

@442623641 what version of the plugin are you using? Before 0.6.0, I think the sound was coming out of the earpiece. Since 0.6.0, the sound comes out of the external speaker correctly.

442623641 commented 6 years ago

Yes，I was installed directly with default version 0.5.8 which is lower 0.6.0，i'll test later. By the way, I see a phenomenon,the impact of energy is a little high ,but i'm not sure ,u can check it. thx

442623641 commented 6 years ago

The plugin is really tough,i think like this useless operations should not be placed at such a high frequency func,but I don't understand oc.eye-measurement there are still many places that are not optimized,would u optimize the following high-frequency operations?after all, this plug-in is really what I want. image

robinbanbury commented 6 years ago

I'm afraid I don't have the authority to do that - the decision would lie with @codinronan, who maintains this plugin. Why don't you submit a Pull Request, or we could work together on this issue? If you are using some kind of performance analysis tool, I'd really like to learn about that.

Just like you, I found this plugin to be really useful, and I'm adding contributions to try to make it even better :-)

codinronan commented 6 years ago

@robincsmith thanks Robin! I merged your other PR's and published 0.6.1, it should appear on NPM in a few minutes... https://www.npmjs.com/package/cordova-plugin-playlist/v/0.6.1

I also added you as a collaborator to the repo so you can help out if you'd like to, just check your email for the invite and accept it if you want to. I can add you to the npm org too if you want so you can publish new versions. I really appreciate your help!

robinbanbury commented 6 years ago

Oh, nice! Thanks @codinronan

@442623641 the offer still stands - if you'd like to work together on this, I'm open to doing that.

codinronan commented 5 years ago

Hey @442623641 @robincsmith I'm publishing a new version this evening that removes that high frequency logging and fixes some other issues. Take a look at 0.7.0

robinbanbury commented 5 years ago

Wow, nice one @codinronan - I see you've made a lot of enhancements! I'm just back off holiday, will have a look at what's changed over the next week