Updated Android Support Library to Android X library

aitJess commented 3 years ago

Description

Updated use of support library for annotations to the androidx library. This is due to the support library no longer being maintained and the androidx library replacing it.

Motivation and Context

This change is required due to android's maintenance of the support library stopping, which may eventually lead to them deprecating the library. This is to future proof the plugin and allow it to work with other updated plugins.

How Has This Been Tested?

Since all it changed was the used libraries for certain function tags -- namely FloatRange, IntRange, NotNull, and Nullable -- I've tested it in my own cordova app and was able to successfully build with Android X Support.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to change) This would cause anyone updating to this latest version to no longer be able to use the plugin when Android X support is disabled.

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.

daveshirman commented 3 years ago

I tried to use this today and I just get the application crashing when it loads on the emulator or my device, this is with Capacitor and Ionic 5 and no other plugins installed.

Error:

android.app.Application cannot be cast to __PACKAGE_NAME__.MainApplication

Any ideas?

aitJess commented 3 years ago

Hello @daveshirman , I cannot think of anything that may cause that off the top of my head but when I have time I'll look into it and update my branch. For the moment there is a plugin that should auto-replace any outdated support libraries for androidx you may use in the future. I had wanted to solve this issue permanently rather than relying on yet another plugin. Here is said plugin, try it with the normal branch for the playlist plugin and see if it resolves your issue. https://www.npmjs.com/package/cordova-plugin-androidx-adapter

Rolamix / cordova-plugin-playlist