search

Roland-J / SmartSkillup

The public release of the SmartSkillup Windower Addon
7 stars 4 forks source link

When skilling up bard skills, the addon tries to start casting the next song too early. #6

Open LordTreyBennett opened 2 years ago

LordTreyBennett commented 2 years ago

The addon attempts to play the next song too early when skilling up brd skills. You can tell because after every song completes you get an error you cannot perform that action and then have to wait 3-4 secs for the sex song.

Steps to Reproduce

Equip a brd with an instrument for which it is under skilled attempt to skill up that skill observe the error message.

*This issues even odccurs with capped Fast Cast.

Expected behavior

no error message and a new song starting about 3 seconds earlier. Maybe be a longer delay if the player has little or no FC.

Roland-J commented 2 years ago

Thank you for submitting this issue.

  1. Is this on retail or a pserver?
  2. Would you be available to chat on discord to have a troubleshooting session?
LordTreyBennett commented 2 years ago
  1. Retail.
  2. Sure. LordTrey#0759 is my discord.

D. "Trey" Bennett

@. @. 225.270.0209

From: Roland-J @.> Sent: Sunday, August 21, 2022 4:46:28 PM To: Roland-J/SmartSkillup @.> Cc: Trey Bennett @.>; Author @.> Subject: Re: [Roland-J/SmartSkillup] When skilling up bard skills, the addon tries to start casting the next song too early. (Issue #6)

Thank you for submitting this issue.

  1. Is this on retail or a pserver?
  2. Would you be available to chat on discord to have a troubleshooting session?

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FRoland-J%2FSmartSkillup%2Fissues%2F6%23issuecomment-1221626553&data=05%7C01%7C%7Cfe096b7571e543efd72608da83be9abb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637967151905061244%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=UUjcL%2FqMR8lJe%2FX9u0jUMnQx8cLcufmud56fiyb7ufg%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAWAFP23GHGSPQXTIDHJ5YJTV2KPTJANCNFSM56PCLT7A&data=05%7C01%7C%7Cfe096b7571e543efd72608da83be9abb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637967151905061244%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=1tvHbibR2IXyra029hqupO8TsXiCyQ7LcswlHk7GjhE%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

Roland-J commented 2 years ago

Sorry for the delay, haven't had time to get on discord to chat. I have a potential root cause in mind; I think your delay is related to a too-short timeout, which is causing a spammed coroutine.close, since that can cause CTD when spammed. Would you try this unpublished version and let me know if it changes your symptom? I've replaced coroutine.close with some closures, to invalidate the scheduled functions via a new coroutine.close-less method. I'm hoping it also stops your symptom from https://github.com/Roland-J/SmartSkillup/issues/7. Thanks! SmartSkillup (test fix).zip

Roland-J commented 2 years ago

Here is a more mature attempt at the fix: it has better rescheduling code in it, a slightly increased timeout/decision delay, and a timeout visual that makes the timeout's stage much more visible when needed (see video below). It still has some pre-release chicken-scratch in it, but please try it and let me know if it mitigates your symptoms. Thanks! SmartSkillup (test fix 2).zip

https://user-images.githubusercontent.com/107378114/187095954-440fdb9e-9075-4b89-8262-444d9cfd870c.mp4

tgotanda commented 2 years ago

I was constantly getting this issue iwth RDM magic skillups until I took a peek at what was happening with debug mode.

Increasing the delay from 2s to 3s on line 171 of SmartSkillup.lua fixed the issue for me, and the timing appears to be perfect on my newly-minted RDM.