search

RolandJansen / intermix

Typescript/Javascript framework for building sequencer-based audio apps
GNU Lesser General Public License v3.0
6 stars 0 forks source link

Change CI/config to just lint but don't fix #131

Closed RolandJansen closed 4 years ago

RolandJansen commented 4 years ago

Followup to #128.

In the current config, lint errors are automatically fixed when possible. We don't want this behaviour in CI because we want to let the user know that things went wrong.

So we need a lint-job without the --fix option.

RolandJansen commented 4 years ago

There should also be a git hook that tries to fix errors to prevent CI from breaking.

RolandJansen commented 4 years ago

Added a prettify task to package.json. The lint task doesn't fix anything (and it doesn't need to). Instead, VSCode fixes lint errors on save and there is a pre-commit hook that also fixes these errors on staged files. See 2e67e7fa85fcc39347efffa74d75aa08b95b6a64