search

RolandKoenig / SeeingSharp

Seeing# is a library that focuses on 3D-Rendering using Direct3D 11. 2D-Rendering, video and sound are also supported. You can use this library for desktop apps (Win.Forms or WPf), WindowsStoreApps or games for XBox One
Other
12 stars 1 forks source link

Switching to SharpDX v4.0.1 this crops up. Do you know which is the correct enum: #2

Open Noemata opened 7 years ago

Noemata commented 7 years ago

I switched libs to SharpDX v4.0.1 and had to add this pragma in Mp4VideoWriter.cs:

using SeeingSharp.Util;

// Some namespace mappings using D3D11 = SharpDX.Direct3D11; using MF = SharpDX.MediaFoundation;

namespace SeeingSharp.Multimedia.DrawingVideo { ///

/// This VideoWriter is responsible for writing mp4 files to hard disc. /// For details see tutorial at: https://msdn.microsoft.com/en-us/library/windows/desktop/ff819477(v=vs.85).aspx /// public class Mp4VideoWriter : MediaFoundationVideoWriter {

if DESKTOP

    private static readonly Guid VIDEO_ENCODING_FORMAT = MF.VideoFormatGuids.H264;

endif

if UNIVERSAL

    // MP! Fixme: resolve correct enum.
    private static readonly Guid VIDEO_ENCODING_FORMAT = MF.VideoFormatGuids.H264Hdcp; // H264Es;

endif

Do you by chance know which is the correct enum to use?

RolandKoenig commented 7 years ago

Not currently, but I can try it myself in the coming days and give you feedback

RolandKoenig commented 7 years ago

I also tried the update to SharpDX 4 yesterday evening and I took the enum MF.VideoFormatGuids.H264Es. I'm not completely sure that this one is right, but sounds better like the Hdcp one (hdcp is for digital content protection). I've not recognized any other problems so far.

Noemata commented 7 years ago

I suspect your choice is a better one. I too did not notice any issues in the transition. I did have to make a few other minor adjustments to get things to build (using VS2017). Please respond to the private email I sent, and we can discuss this a little further.