Rename toggle to switch - Githubissues

RoleModel / optics

Optics, a RoleModel Design System is an scss package that provides base styles and components that can be integrated and customized in a variety of projects.

https://docs.optics.rolemodel.design

MIT License

15 stars 0 forks source link

Rename toggle to switch #192

Closed Jeremy-Walton closed 1 year ago

Jeremy-Walton commented 1 year ago

Why?

In order to support aria roles and consistent naming in the future, we want to rename toggle to switch.

Note: I did not introduce the role of switch since:

It may require other changes and want think through them. See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/switch_role
We have a task to do this in the future. See https://trello.com/c/DotKJBw8/131-aria-considerations

What Changed

[X] Rename
[X] Fix label after toggle
[x] Add documentation pointing to RoleModel Rails Simple Form Custom Input

Sanity Check

[X] Have you updated any usage of changed tokens?
[X] Have you updated the docs with any component changes?
[X] Have you updated the dependency graph with any component changes?
[X] Have you run linters?
[X] Have you run prettier?
[X] Have you tried building the css?
[X] Have you tried building storybook?
~~Do you need to update the package version?~~

Jeremy-Walton commented 1 year ago

This fixes https://github.com/RoleModel/optics/pull/185

Jeremy-Walton commented 1 year ago

Switch (formerly Toggle)