search

Roleren / ORFik

MIT License
33 stars 9 forks source link

could not find function "detectCores" #116

Closed bartma11 closed 3 years ago

bartma11 commented 3 years ago

Hi, while working through Ribo-seq pipeline example from vignette I encountered an error. detectCores_issue

Manually loading parallel package seems to resolve this issue. detecCores_resolution

Is this desired behavior for some reason? If not, would it be a good idea to add parallel to imports?

For reproduction
R: 4.1.1
ORFik: 1.13.14

Roleren commented 3 years ago

Yes, this is a corner-case bug, when R was not importing parallel indirectly through BiocParallel.

I now made the core check more safe using BiocParallel::bpparam()$workers. Which has should always work.

Roleren commented 3 years ago

Close issue if there is nothing else :)