search

Roleren / ORFik

MIT License
32 stars 9 forks source link

Makar Issue - Incorrect Assignment of PMID #149

Closed JackCurragh closed 12 months ago

JackCurragh commented 12 months ago

The SRA Entrez API within ORFik incorrectly assigns studies with the PMID of 1 where no other valid PMID is found. This means a lot of studies end up being by Makar et al. when assigned via ORFik.

I suspect this line is to blame.

Setting the default to 0 instead will not return a valid record from entrez but I am not sure how to test what impact this will have on the rest of the API.

Roleren commented 12 months ago

Thank, will check it out within a few and push if it works :)

Roleren commented 12 months ago

Ok, fixed, this was stupid, have no idea why I set it to default 1, I now set it to as.numeric(NA), and it works as it should, haha :D