Rolf-Hempel / PlanetarySystemStacker

Produce a sharp image of a planetary system object (moon, sun, planets) from many seeing-affected frames according to the "lucky imaging" technique.
275 stars 32 forks source link

--debayering Grayscale CLI arg not being picked up #56

Closed Gero-B closed 2 years ago

Gero-B commented 2 years ago

Hi, I've been attempting to automate my workflow using the PSS CLI and discovered that I'm getting different results when running via GUI and CLI given the same set of configuration params. Mainly --debayering Grayscale still results in a color image.

Confirming it was read properly by arg parser:

           Stacking parameters:                                         | Value                        |
           ---------------------------------------------------------------------------------------------
           Debayering default                                           | Grayscale                    |
           Debayering method                                            | Bilinear                     |
           Noise level (add Gaussian blur)                              | 7                            |
           Frame stabilization mode                                     | Surface                      |
           Automatic frame stabilization                                | True                         |
           Stabilization patch size (% of frame size)                   | 33                           |
           Stabilization search width (pixels)                          | 34                           |
           Percentage of best frames for reference frame computation    | 5                            |
           Object is changing fast (e.g. Jupiter, Sun)                  | False                        |
           Alignment box width (pixels)                                 | 48                           |
           Max. alignment search width (pixels)                         | 14                           |
           Minimum structure                                            | 0.04                         |
           Minimum brightness                                           | 10                           |
           Percentage of best frames to be stacked                      | 10                           |
           Normalize frame brightness                                   | False                        |

FIle is .mp4 format

full command for above output: planetarysystemstacker DSC_0001_003.mp4 --debayering Grayscale --protocol_detail 2

Might just be missing something obvious

Rolf-Hempel commented 2 years ago

Hi Gero,

Thanks for telling me about this problem. At the moment I don't have access to my developing environment. I will have a look at the issue next week.

Was the debayering option the only cause for different behavior between GUI and CLI?

All the best, Rolf

Gero-B commented 2 years ago

Thanks for the help, so far debayering is the only option I've noticed behaving differently. As a workaround I've been converting my inputs to grayscale before processing so it's not a pressing issue

Danke!

Rolf-Hempel commented 2 years ago

Hi Gero,

the bug is fixed. I created a new PSS version (0.9.3) and uploaded it to PyPi.

All the best, Rolf