search

Rolf-Hempel / PlanetarySystemStacker

Produce a sharp image of a planetary system object (moon, sun, planets) from many seeing-affected frames according to the "lucky imaging" technique.
275 stars 32 forks source link

Update spec files to work with pyinstaller 5.13.2 #75

Closed castorf closed 1 year ago

castorf commented 1 year ago

pyinstaller knows about astropy and scikit. Use pathlib for common directories

Rolf-Hempel commented 1 year ago

Did you try running pyinstaller with your specifications? With the files I used in the past, pyinstaller did not work for a long time. It would be great if I could use pyinstaller to produce a Windows installer again.

castorf commented 1 year ago

Yes. I ran this by using something like:

conda create -n pss python=3.9 pyinstaller conda activate pss pip install planetary-system-stacker pip uninstall planetary-system-stacker cd planetary_system_stacker

pyinstaller planetary_system_stacker_windows.spec

castorf commented 1 year ago

I'm trying to set up a custom packaging working with debinitiative.org because we want to use PSS with scripted processing of images. Chris Mandrell made some modifications to be able to do post processing from the command line. I'm not sure if it's "the right thing" but we want a windows installer to reduce the cognitive load on our citizen scientist team members.

Rolf-Hempel commented 1 year ago

That's great news! Many people complained that the Windows installer is quite outdated and everybody had to install Python and use pip for PSS. But I could't get pyinstaller to process PSS correctly.

I had not included postprocessing in the command line version of PSS because postprocessing is a relatively lightweight operation which I prefer to do in interactive mode (including the "automatic" / batch option. Meanwhile one user asked me for a command line version of postprocessing. But I'm not sure yet if I want to do that.

castorf commented 1 year ago

Well, I hope it works for more than just me... I had to tweak some stuff with installforge because it wasn't looking where pyinstaller was putting the output, but I think it worked after that.

I have not done much actual image processing so I don't understand the subtleties of when to do what, but we'd like to do a first pass in an automated way so we can share results live.

On Fri, Sep 1, 2023 at 12:13 PM Rolf Hempel @.***> wrote:

That's great news! Many people complained that the Windows installer is quite outdated and everybody had to install Python and use pip for PSS. But I could't get pyinstaller to process PSS correctly.

I had not included postprocessing in the command line version of PSS because postprocessing is a relatively lightweight operation which I prefer to do in interactive mode (including the "automatic" / batch option. Meanwhile one user asked me for a command line version of postprocessing. But I'm not sure yet if I want to do that.

— Reply to this email directly, view it on GitHub https://github.com/Rolf-Hempel/PlanetarySystemStacker/pull/75#issuecomment-1703215868, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPQH34FRQWX2DP5IWA74O3XYIXUJANCNFSM6AAAAAA4HZSJGU . You are receiving this because you authored the thread.Message ID: @.***>

Rolf-Hempel commented 1 year ago

I accepted the pull request, but I did not try it out yet. Tomorrow I leave for vacations, so I don't have much time right now. I will look at it when I return.

Thank you very much for your great initiative. That helped me very much!