Rolf-Hempel / PlanetarySystemStacker

Produce a sharp image of a planetary system object (moon, sun, planets) from many seeing-affected frames according to the "lucky imaging" technique.
274 stars 32 forks source link

Qt6 issues #76

Open mdolenga opened 1 year ago

mdolenga commented 1 year ago

Hi - I was investigating what it would take to port the app to Qt6 and while it generally goes smoothly, I'm running into an issue with this pattern:

options = QtWidgets.QFileDialog.Options()

On PyQt5, this works. On PyQt6, python3.11 complains as follows:

AttributeError: type object 'QFileDialog' has no attribute 'Options'. Did you mean: 'options'?

As I understand the code here, the goal is to allow both file or directory selection in a single QFileDialog, which does require some extra work. I can't find any mention of an API change in QFileDialog which would account for this, but will keep digging.

If anyone has an idea on how to proceed, I'd be interested to know. I'd love to contribute to this project, it runs so well on my M1 Mac; if I could get permission to create a PR on a Qt6 port I would appreciate it.

Rolf-Hempel commented 1 year ago

Hi Michael,

As I just wrote on CN, I would be happy to accept a pull request regarding a code port to QT6, if the code is tested on Windows, Linux and Mac. I'm looking forward to hearing from you!

All the best, Rolf