Bypassing the adapter?

[bytheway875]

As it stands, each has_role? call queries the db using the kind-of-complicated query in the adapter. In our app internally, because we eager-load roles with User, this is very heavy and seems kind of unnecessary. So we wrote our own has_role? method that more closely resembles the new record implementation of the method and its working really well so far. So I have a couple of questions:

• Why the adapter? From what I can tell, its because of the differences between ActiveRecord and Mongoid? But are there other functional reason to have these methods query the db every time?
• If it isn't fully necessary to have it hit the db every time, would it be possible to add an implementation of has_role? and the other finders that bypass the adapter? There would be like a config variable that you set to bypass the adapter, and if that's set to true, you don't have to hit the db on every query.

Anyways, I'm not too sure whether this is something that is feasible or necessary or wanted, but its how we've adapted rolify to work internally. If it is a feature we can add, I'm more than willing to work on it!

[tinynumbers]

Could you share your implementation of has_role??

I ask because I've taken the same approach to cut down on what I also see as unnecessary role queries. My implementation is exactly like the new record implementation:

  def has_role?(role_name, resource = nil)
    self.roles.detect { |r| r.name == role_name.to_s && (r.resource == resource || resource.nil?) }.present?
  end

Works for me, but just wanting to make sure I'm not overlooking anything.

[jbyers16]

We're currently testing adding a role collection present check. So far seems to work for eager and non-eager loaded roles.

def has_role?(role_name, resource = nil)
    if new_record? || self.roles.present?
      role_array = self.roles.detect { |r| r.name.to_s == role_name.to_s && (r.resource == resource || resource.nil?) }
    else
      role_array = self.class.adapter.where(self.roles, name: role_name, resource: resource)
    end

    return false if role_array.nil?
    role_array != []
  end

[tinynumbers]

Thanks @jbyers16

[wldcordeiro]

If you guys find a better solution that works with Mongo we'd love a PR.