"Reroll Until" doesn't appear to work with "Keep"

Rolisteam / DiceParser

Powerful dice Roller is used as discord bot, irc bot, cli tool and inside Rolisteam : 1d20+4, 1L[head,arm,leg,belly,chest], 1d6+1d8, 8+5*3

http://www.rolisteam.org/

GNU General Public License v3.0

125 stars 31 forks source link

"Reroll Until" doesn't appear to work with "Keep" #80

Open FedoraMark opened 4 years ago

FedoraMark commented 4 years ago

While testing out the Keep and Reroll/Reroll Until commands it appears that Keep followed by Reroll Until doesn't work, while Reroll does work in the same place:

!4d6k3R[>8] doesn't work

!4d6k3r[>8] works

obiwankennedy commented 4 years ago

it is normal that : !4d6k3R[>8] does not work as you can't be above 8 with a d6.

ErrorCondition ("{9beafc0e-e1cf-4ecb-8dac-b4a5e506e939}" [label="RerollDiceNode validatior: "]) cause an endless loop with this dice: d[1,6]

FedoraMark commented 4 years ago

So it doesn't use the total of the 4d6k3? I see.

obiwankennedy commented 4 years ago

To use the total, it will be: !4d6k3R[:>8] but R does not support smart validators. I will check that.