search

Rolisteam / rolisteam

Rolisteam is a virtual tabletop. It helps you to manage tabletop role playing games with remote friends/players. It provides many features to share maps, pictures, dice roller, manage background music and much more. The main git repository is available here: [https://invent.kde.org/kde/rolisteam].
http://www.rolisteam.org/
Other
187 stars 27 forks source link

fix crash when removing several items in resources list #85

Closed EtienneCoumont closed 5 years ago

EtienneCoumont commented 5 years ago

Hello,

I encountered a crash when removing 2 items from the resources list. Here is the fix.

Weird thing : crash does not happen with release version of 1.8.2. Maybe Qt added some tests in latest versions ? I'm using Windows / Qt 5.10.1 / Qt Creator 4.6.2.

obiwankennedy commented 5 years ago

Does it mean you are using Rolisteam 1.9 compiled from the source ?

EtienneCoumont commented 5 years ago

yes. I tested with the latest version from github

obiwankennedy commented 5 years ago

Don't hesitate to make comments about what you see. I will be glad to have another point of view about new features. Which version of visual studio do you use ? This week end I tried rolisteam on windows I got issue about the tipchecker/tifofthedayviewer. When did you get the source ? Sorry if I'm curious.

Thank for the patch!

EtienneCoumont commented 5 years ago

Seems great for now, but I'm new to Qt so it's hard for me to comment :) I'm using msvc2017 for compilation. I made another request to fix tipofday.