search

Roll20 / roll20-character-sheets

Character sheet templates created by the community for use in Roll20 VTT. Submit a ticket at roll20.net/help if critical hotfixes are to be requested.
https://roll20.net/
MIT License
1.17k stars 4.16k forks source link

[Mutant Year Zero] Merged pull request #10153 not published #10188

Closed dwarfwing closed 2 years ago

dwarfwing commented 2 years ago

The PR [Mutant Year Zero] Fixed buddy checkbox #10153 was merged but does not appear anywhere, not in production and not on the dev server. All sheets still state version 2.03 and not 2.04, and the issue the PR fixes is still there. It is a small change but a bug fix so without it players will continue experiencing this issue.

Can someone please look into this?

nmbradley commented 2 years ago

Hi @dwarfwing

I've manually updated the sheet on the server. Are you able to verify for me that the change is now visible?

dwarfwing commented 2 years ago

I checked one of my test and the game we will play tomorrow, and the version is updated and the fix is there. Thanks for your help, much appreciated!

Is there anything I did wrong that caused this or was it a github or build pipeline issue? Anything that I or the community can do to avoid this happening?

nmbradley commented 2 years ago

I think we've identified a race condition where really small updates make their way through the build pipeline faster than our server expects. I don't think there's anything you can do to mitigate it (other than make larger PRs, which is dumb), we'll have to hunt it down on our end.

This was a good test case to start identifying the issues though, so thanks!

dwarfwing commented 2 years ago

@nmbradley, could I ask you to also look at the PRs [Alien RPG] Fixed ship armament rolls #10159 as it is also not appearing in spite being merged 3 days ago? Please let me know if you want me to open a separate Issue for this.

[AlienRPGroller] v2.00 - Updating stress on pushing roll #1451 is also pending review and merge, but I believe the API scripts go on a different PR review schedule. Can you let me know what is the schedule for reviewing and merging API Script PRs?