Roll20 / roll20-character-sheets

Character sheet templates created by the community for use in Roll20 VTT. Submit a ticket at roll20.net/help if critical hotfixes are to be requested.

https://roll20.net/

MIT License

1.16k stars 4.15k forks source link

Fix: A Song of Ice and Fire: Fix Balance roll, fix HTML issues, add 2 custom abilities #13070

Closed Riernar closed 3 months ago

Riernar commented 3 months ago

Submission Checklist

Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description

In this PR, following this forum post and the original author not responding, we:

Fix the roll for the "Balance" ability by adding the missing end of the roll formula
Fix various HTML issues in the sheet detected by Prettier: 2 missing closing tags, and one closing tag of the wrong type (span instead of label)
Upon user request, we add two custom abilities, at the bottom of the sheet, to support custom/houserules abilities. Those are modelled after the language section except they've been made a bit more compact

roll20deploy commented 3 months ago

Character Sheet Info Roll20 Internal Use only.