Roll20 / roll20-character-sheets

Character sheet templates created by the community for use in Roll20 VTT. Submit a ticket at roll20.net/help if critical hotfixes are to be requested.

https://roll20.net/

MIT License

1.16k stars 4.13k forks source link

Star wars 5E : NPC layout improvement #13074

Closed BE-Arbiter closed 1 week ago

BE-Arbiter commented 3 weeks ago

Submission Checklist

Required

[X] The pull request title clearly contains the name of the sheet I am editing.
[X] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[X] The pull request makes changes to files in only one sub-folder.
[X] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description

Change the layout of the npc sheet to have two columns (like it's Dnd-5 Counterpart)
Add the possibility to switch between edit and view for the traits. Like the actions

roll20deploy commented 3 weeks ago

Character Sheet Info Roll20 Internal Use only.

BE-Arbiter commented 3 weeks ago

@speedreeder @Anduh @Fresnoth For review

BE-Arbiter commented 2 weeks ago

Thank you,

As I will master a tcw campaign in a few month I will certainly do more.

Anduh commented 2 weeks ago

If the sheet would be upgraded from using the Legacy sheet, some things would open up for you, like using datalist could be handy for storing names of Tech and Force power names, giving an autocomplete option for them. The D6 Star Wars sheet is a fairly simple example on how datalists could be used.

comradedangerfloof commented 1 week ago

The text of the actions are aligned to the left and the traits do not display any text other than their name. Also when clicking on the traits to display them in chat, an error occurs. Also the traits are a bit hard to click on.

BE-Arbiter commented 1 week ago

Will look into this as soon as possible.

BronsonHall commented 1 week ago

@BE-Arbiter If needed I can revert this pr until the problem can be addressed. If you're working on this now or will have a fix pr up soon, just @ me as soon as that's in so I can get it merged.

BE-Arbiter commented 1 week ago

Yes, please revert I on travel til sunday :)

Anduh commented 3 days ago

My bad, I clearly didn't test this well enough. Should have filled out a more complete NPC and poked around a bit more.

@BE-Arbiter , would it be possible for you to create & share a campaign were other users could help with testing? (IIRC only the game creator can update code if custom character sheet is used, so me creating a game wouldn't help you much)

Enabling character import in the game, others people could import actually used characters with lots of data to the test game, so both you and others could better test things. When I was more active with sheet development, at times I hosted similar test games for other sheets when I did larger updates to sheets.

Sharing campaign link

If a public invite link results in spammers/bots joining the game, kicking a player will invalidate the old invite link, and a new one is given.
Alternatively, link you roll20 profile or a forum post here about the test game, and DM the invite to people who contact you

BE-Arbiter commented 3 days ago

Nice idea, will do it next week.