search

Roll20 / roll20-character-sheets

Character sheet templates created by the community for use in Roll20 VTT. Submit a ticket at roll20.net/help if critical hotfixes are to be requested.
https://roll20.net/
MIT License
1.16k stars 4.14k forks source link

[FIX MERGED] [WFRP-2nd-Ed] Broken Characteristics Rolls #1518

Closed Silvyre closed 8 years ago

Silvyre commented 8 years ago

@Wrathborn @timothystone

https://app.roll20.net/forum/post/3133323/wfrp-bug-warhammer-fantasy-role-play-sheet

The issue appears to be that it is not possible to /roll within an emote.

Silvyre commented 8 years ago

https://app.roll20.net/forum/post/3144850/warhammer-2nd-edition-rpg-main-profile-problem

timothystone commented 8 years ago

Submitted pull request to address the issue. Unsure of reason for loss. However, @Wrathborn 's commit did significantly reformat the sheet. Some entity encoding was lost and this broke the buttons inline macros. I've restored the entity encoding and formatting.

timothystone commented 8 years ago

Pull Request #1530 in queue. Assign and close.

timothystone commented 8 years ago

@Silvyre you can assign #1518 to me if you like. That way I can mark it closed when it is merged to master.

timothystone commented 8 years ago

@Silvyre you can close this. Merge to master is complete.

timothystone commented 8 years ago

Reopen. Validation in production failed. Checked the repo, the code is there, but the merge seems to have purged it. Looking for another solution.

pjbehr87 commented 8 years ago

It's merged, it not live yet

timothystone commented 8 years ago

@pjbehr87 thanks!

pjbehr87 commented 8 years ago

We don't like to make server pushes in the afternoon while the site is the most busy, it will most likely happen tomorrow morning sometime. Look for it at least after mid-day tomorrow to be sure.

timothystone commented 8 years ago

I've validated in production. #1530 looks fixed.

timothystone commented 8 years ago

Please Close @Silvyre