search

Roll20 / roll20-character-sheets

Character sheet templates created by the community for use in Roll20 VTT. Submit a ticket at roll20.net/help if critical hotfixes are to be requested.
https://roll20.net/
MIT License
1.17k stars 4.16k forks source link

Godbound: HP Miscalculation #2017

Closed mturner95 closed 6 years ago

mturner95 commented 8 years ago

Current implementation for calculating HP from constitution modifier located in 'Godbound.html' is incorrect:

"8 + 4*(@{adj_level}) + ceiling((@{adj_level}) * (@{con_mod}) / 2)" Yields improper increase in HP via constitution modifier for odd numbered levels.

Suggested fix should appropriately calculate per level HP increase with respect to constitution modifier: "8 + (@{con_mod}) + (@{adj_level})*(4 + ceiling((@{con_mod}) / 2))"

Anduh commented 7 years ago

Did anyone follow up on this? This guy https://github.com/Roll20/roll20-character-sheets/issues/3017 also found it.

clevett commented 6 years ago

Hello @ChosenCyan ,

Do you know if this is still an issue? I'm trying to follow up on old issue tickets.

Thanks, Cassie

Anduh commented 6 years ago

This sheet got replaced with a new sheet one month ago, so shouldn't be possible that this would still be an issue. https://github.com/Roll20/roll20-character-sheets/pull/3854 @Almos80 I assume this issue can be closed as irrelevant, because you replaced the old sheet with 100% new sheet?

clevett commented 6 years ago

@Anduh Thanks for the info! I see that complete redesign back in June. I'll give Alamos80 a chance to response and if I don't hear back in a few days then I'll close this issue.

Almos80 commented 6 years ago

This issue can be closed since the redesign has changed this calculation.