search

Roll20 / roll20-character-sheets

Character sheet templates created by the community for use in Roll20 VTT. Submit a ticket at roll20.net/help if critical hotfixes are to be requested.
https://roll20.net/
MIT License
1.17k stars 4.16k forks source link

[SavageWorldsFrench] "Conduite" displays "Combat" #4508

Closed Arnok13 closed 5 years ago

Arnok13 commented 5 years ago

Hi, the display for Conduite Skills is now Combat (we can have two times Combat skill) :

data-i18n="combat">Conduite

there is a mistake in HTML file

Best regards, Arnok

clevett commented 5 years ago

I thought I fixed this in my last push. I'll get it fixed this weekend.

Arnok13 commented 5 years ago

thanks.

clevett commented 5 years ago

You're welcome. PR 4509 should fix this. I found the tags wrong in two places.

Arnok13 commented 5 years ago

the OPTION without a ">" at the end ?

clevett commented 5 years ago

Is there an option without an ">" ?

The two things I fixed were the data-i18n="" were using "combat" instead of "conduite". Simple mistake when I put in all the tags.

Arnok13 commented 5 years ago

Visual Studio Code show me 2 OPTIONS without ">" (but can't remember where i fixed them when proptotyping a SWADE version)

clevett commented 5 years ago

Yep! I found them. I'll push an update for those as well.

Arnok13 commented 5 years ago

you're the best ;)

clevett commented 5 years ago

There was more than two. I think they are all fixed now. If you find anything else or any just general suggestions for improvement let me know. :) The original author and I are looking to do future updates.

Thanks, Cassie

Arnok13 commented 5 years ago

i'm looking for adapting this sheet to the new edition of Savage World : Adventure Edition and may be to introduce new settings (Last parsec, Flash Gordon, Highspace, Fear Agent, Rippers, ...). But i have not practised HTML for a long time.

NathaTerrien commented 5 years ago

@Arnok13 I've got plans to do the SWADE adaptation begining of 2019, and more (notably replacing some dynamic calculations by sheet workers function). If you can wait (and have not practiced sheet programming), I would suggest waiting for this update :)

Arnok13 commented 5 years ago

great news !

clevett commented 5 years ago

Changes for this should be live. Can you double check this is working?

Arnok13 commented 5 years ago

Seems perfect !

Arnok

Arnaud

From: Cassie Levett notifications@github.com Sent: Tuesday, December 18, 2018 7:44:11 PM To: Roll20/roll20-character-sheets Cc: Arnok13; Mention Subject: Re: [Roll20/roll20-character-sheets] [SavageWorldsFrench] "Conduite" displays "Combat" (#4508)

Changes for this should be live. Can you double check this is working?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Roll20/roll20-character-sheets/issues/4508#issuecomment-448326309, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AET4bpKXmbtYVh_rp4CS4PgiEJOG2Efoks5u6Td7gaJpZM4ZUYYu.