search

Roll20 / roll20-character-sheets

Character sheet templates created by the community for use in Roll20 VTT. Submit a ticket at roll20.net/help if critical hotfixes are to be requested.
https://roll20.net/
MIT License
1.16k stars 4.15k forks source link

[RunequestGQS] Add data-i18n tags to the sheet #5300

Closed dyvim closed 4 years ago

dyvim commented 5 years ago

The game RuneQuest Roleplaying in Glorantha will soon be translated in french (the quickstarter is already translated) I supose that this game will probably be translated in Spanish and German too (or already is). So I think that data-i18n tags should be added if possible.

So if @Lockbox313 is able to add them it will be cool and probably very appreciated.

If he doesn't have the time, I can try to add the tags and provide a new html file, but I will need help to generate the translation.json file (cause I have no pro account for the moment)

BRgds

Lockbox313 commented 5 years ago

That is not something I am interested in doing. There is quite a bit of HTML in there so you would need to allocate quite a bit of time to do it. While you are doing this all further development would have to cease.

Lockbox313 commented 5 years ago

You will need to change the sheet worker that adds the skills and use getTranslationByKey to get the translated skill names.

dyvim commented 5 years ago

OK. I'll try to do that by myself. (it's not the first time :)) Someone gave me a script that is supposed to generate automatically the tags... It's a good occasion to test it.

Do you you mind if I send to you the new html file as I won't be able to generate the translation.json file?

Lockbox313 commented 5 years ago

Who gave you the script? You mean get someone else to test it as you don't have a PRO account.

Anduh commented 5 years ago

You mean the ACSI script? Yeah it' works on well-structured html,and on some sheets might generate something that is a timesaver on on other sheets. I advise to remove sheetworkers from any file you run through the acsi, as it only expects html in the files, doing quite a number otherwise. ACSI can to a limited capacity also generate a translation.json file when it inserts the i18n tags into the html file.

Lockbox313 commented 5 years ago

@Anduh is this the script you used on the Monsterhearts 2 sheet?

Anduh commented 5 years ago

Yeah. Monster heart was a sheet it didnt work well for, but the script have done better on other sheet, think there are now like 5 sheet that have been translated mostly by ACSI.

Lockbox313 commented 5 years ago

Which sheets were they?

On Fri, 12 Jul 2019 at 12:00, Andreas J. notifications@github.com wrote:

Yeah. Monster heart was a sheet it didnt work well for, but the script have done better on other sheet, think there are now like 5 sheet that have been translated mostly by ACSI.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Roll20/roll20-character-sheets/issues/5300?email_source=notifications&email_token=ACET77PDH5FYQNAOUVSJ2ATP7BP3PA5CNFSM4IBH2PK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZZOA6I#issuecomment-510845049, or mute the thread https://github.com/notifications/unsubscribe-auth/ACET77JWBSPWXEXDCO4TML3P7BP3PANCNFSM4IBH2PKQ .

Anduh commented 5 years ago

Forbidden Lands, Nemesis, Over the Edge, Chronicles of Darkness by Roll20, Cyperpunk2020.

dyvim commented 5 years ago

You mean the ACSI script? Yeah it' works on well-structured html,and on some sheets might generate something that is a timesaver on on other sheets. I advise to remove sheetworkers from any file you run through the acsi, as it only expects html in the files, doing quite a number otherwise. ACSI can to a limited capacity also generate a translation.json file when it inserts the i18n tags into the html file.

Yes I mean this script

Anduh commented 5 years ago

Yes I mean this script

I'm looking forwards seeing someone else than just me use it :D

Lockbox313 commented 5 years ago

To do successfully do this you will have to take out the html that pertains only to Runequest:Glorantha sheet as the file also contains a sheet based on the RQ3 sheet that was done before the rules were released. After you run that through the script you will have merge back into the file and then it needs tested by someone who has a pro account. Since you do not have a PRO the only thing you can do is tidy up the JSON keys and data-i18n in the HTML.

Lockbox313 commented 5 years ago

Here is a version of the HTML with Quick start sheet removed and the sheet workers removed. https://github.com/Lockbox313/Roll20-Testing/blob/master/RQ-Translation/RunequestGQS.html

dyvim commented 5 years ago

Hmmm I didn't remember ACSI was developped for Linux... Do you think a windows executable could be generated with the sources @Anduh ? I don't have a Linux OS installed at the moment

Anduh commented 5 years ago

Do you think a windows executable could be generated with the sources?

I doubt it. Pretty sure one or two of the core libraries making ACSI into a command line tool are Unix-dependent. Making it Windows-compatible is pretty low on the todo-list, and I haven't really had time improving it lately so that will likely not happen this decade...

Anduh commented 5 years ago

Here is the result of running ACSI, and some minor cleanup before and after, and added back the sheetworkers & rolltemplates.

Unfortunate there seems to be some serious flaw with the end result, as it doesn't want to display at all if tried in a custom game. I fixed some minor html/css mistakes on the sheet, and ran it through a validator, but couldn't figure out why it isn't working. My only guess is that I changed something that the sheetworkers didn't like, which disables the sheet.

Guess the script wasn't much help this time, probably best to do the translation form scratch, unless someone can figure out with a quick glance what's wrong.

Lockbox313 commented 5 years ago

I pulled something together with VBA (I would have used C# but I don't have VS studio installed on this machine.) It does divs, spans and, labels Here is an invite to the test game https://app.roll20.net/join/4461254/F7DxUQ

Lockbox313 commented 5 years ago

@dyvim Are you still interested in this? If you are it would help if you did some testing on sheet in the game linked above.

dyvim commented 5 years ago

Hello, I'm still interested but i am at the hospital for at least one week. BRgds

Le mer. 17 juil. 2019 10:52, Lockbox313 notifications@github.com a écrit :

@dyvim https://github.com/dyvim Are you still interested in this? If you are it would help if you did some testing on sheet in the game linked above.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Roll20/roll20-character-sheets/issues/5300?email_source=notifications&email_token=ACDCHUWOISINUBCUAHPCVCLP73MUJA5CNFSM4IBH2PK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2DQHGA#issuecomment-512164760, or mute the thread https://github.com/notifications/unsubscribe-auth/ACDCHUXXDZUKJEYFKRUO7BDP73MUJANCNFSM4IBH2PKQ .

Lockbox313 commented 5 years ago

I will have to redo the data-i18n tags as I had to issue a fix. No ETA on that.

dyvim commented 5 years ago

I did some tests in your test game. All seems to work correctly but I can not be completely sure as all the text was in english (logical as fr.json has not been initialized I suppose)

Lockbox313 commented 5 years ago

It will have to be redone as I had to issue a fix. I am in the middle of something else so as I said above no ETA when I will get back to it.

Anduh commented 4 years ago

How did this turn out? I might have time to help out Summer 2020 with creating more translations for Roll20 sheets.

Lockbox313 commented 4 years ago

I wrote something which added the tags and didn't mangle anything but I had to make changes to the sheet before the OP returned to look at. I have not had time to redo it.

Lockbox313 commented 4 years ago

I ran the latest version through the vba app and tidied it up but as this is auto generated it really needs a thorough testing which I do not have time for. Not sure who is going to do the testing as the OP has stated his English is not good enough for testing. Here is the test game https://app.roll20.net/join/5708059/jCIr0Q

dyvim commented 4 years ago

Hello. My english is not the problem (I'm pretty fluent). My problem was that as there is no other language than english in the json files. So we can't see if the data-i18n tags works correctly. But I can still detect bugs. I will join your test game and do some tests..

Lockbox313 commented 4 years ago

The sheet is functioning from json the actual language doesn't matter.

Anduh commented 4 years ago

Although if you try the sheet without the json, you should see red for all the text, and notice if some section is missing a tag, but that's a much smaller problem. If no red text is seen in the test game with he json, it means any bugs/mistakes on the translations is minimal.

Lockbox313 commented 4 years ago

The issue is this was auto generated as opposed to working through thousands of lines of code. That means it needs a lot of testing . Somebody has to do that work. It is very easy to say I want this character sheet done or I want tags in this sheet and then sit back and wait for someone to do that work

Anduh commented 4 years ago

Yes, and the massive amount of manual work was also why I turned down to work on this particular sheet's translation tags, beyond offering what my half-assed script generated. I've helped translate about 8 or so sheets over the last year or so, but it have been those smaller ones that my script worked well with, making reliable heavy lifting with the manual work.

It's possible I'll rewrite the script in python later this spring, as part of a course I'm currently taking, so that combined with me becoming more effective with these kind of things, I might take a jab at this later.

Lockbox, do you have a gist or a repo where you have the sheet code you have in that linked test campaign? And @dyvim , maybe you know people who'd be interesting in testing Lockbox's current version, and see if they find any bugs with it? If Lockbox would share the current translation.json file, people could start translating it, considering whatever it contains wouldn't change much to a final version.

Lockbox313 commented 4 years ago

The majority of it is done as can be seen in the test game accept for roll templates

On Tue, 21 Jan 2020 at 13:10, Andreas J. notifications@github.com wrote:

Yes, and the massive amount of manual work was also why I turned down to work on this particular sheet's translation tags, beyond offering what my half-assed script generated. I've helped translate about 8 or so sheets over the last year or so, but it have been those smaller ones that my script worked well with, making reliable heavy lifting with the manual work.

It's possible I'll rewrite the script in python later this spring, as part of a course I'm currently taking, so that combined with me becoming more effective with these kind of things, I might take a jab at this later.

Lockbox, do you have a gist or a repo where you have the sheet code you have in that linked test campaign? And @dyvim https://github.com/dyvim , maybe you know people who'd be interesting in testing Lockbox's current version, and see if they find any bugs with it? If Lockbox would share the current translation.json file, people could start translating it, considering whatever it contains wouldn't change much to a final version.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Roll20/roll20-character-sheets/issues/5300?email_source=notifications&email_token=ACET77JL53DKWEMVTSNRDK3Q63X5LA5CNFSM4IBH2PK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJPVPSA#issuecomment-576673736, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACET77OA26CCAP2JH5CADV3Q63X5LANCNFSM4IBH2PKQ .

Anduh commented 4 years ago

Have you run the code through some HTML validator? Was the main reason I was asking for the code...

Edit: Having give the sheet a quick look, it seems to be working sensibly, and only a handful of places don't have translations, if the large equipment/skill section are excluded.

Lockbox313 commented 4 years ago

If there an been an issue with the display I would have done that but everything displays correctly. What HTML validators cannot pickup is button types being changed from roll to submit this sort thing requires someone to go press buttons and fill inboxes.

On Tue, 21 Jan 2020 at 13:57, Andreas J. notifications@github.com wrote:

Have you run the code through some HTML validator? Was the main reason I was asking for the code...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Roll20/roll20-character-sheets/issues/5300?email_source=notifications&email_token=ACET77PYVMG3IU2KROZPFR3Q635MZA5CNFSM4IBH2PK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJP2HTI#issuecomment-576693197, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACET77K6PEIV42VXO5FDBGLQ635MZANCNFSM4IBH2PKQ .

dyvim commented 4 years ago

I've done some tests on your test game. Everything seems OK The rolls works correctly No display trouble, no text in red except what is specified to be in red. ( a tiny url at the top of the sheet and a special paragraph at the bottom for magic notes) I think there is no data-i18n tag that miss a line in the translation.json.

Thanks for all the work

dyvim commented 4 years ago

@Lockbox313 Do you think my tests are sufficient? Will you submit the modifications?

Lockbox313 commented 4 years ago

A large number of roll tables still need to be done. Pressing the same handful of buttons for 20 minutes would not have caught that.

On Sun, 2 Feb 2020 at 15:25, Thomas Coquery notifications@github.com wrote:

@Lockbox313 https://github.com/Lockbox313 Do you think my tests are sufficient? Will you submit the modifications?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Roll20/roll20-character-sheets/issues/5300?email_source=notifications&email_token=ACET77J3H6XVPIETDH2GDULRA3QXJA5CNFSM4IBH2PK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKRZLJQ#issuecomment-581146022, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACET77I3EHRLI5MQB37AYA3RA3QXJANCNFSM4IBH2PKQ .

Lockbox313 commented 4 years ago

Ok. I finally got this done. I am sure there is something buried in there that I missed but that will have to come out in the wash for the sake of my sanity. I have not done the hit locations and fumbles for the quick start but any sane person should not be using that now..

dyvim commented 4 years ago

thanks a lot this is very timely because the pdf of the french translation for RQG will be delivered in the coming days I'll begin the translation as soon as your work will be commited BRgds

Lockbox313 commented 4 years ago

This will probably be delayed as someone made a bunch of mostly cosmetic changes a few hours before before my pull request.

Lockbox313 commented 4 years ago

The merged failed because of the changes made by another contributor . I have tried to fix this but it is difficult because I have no easy way of checking what the problem is because github desktop app requires a 64 bit o/s. If this pull fails I will abandoned this update and probably any other support for this sheet.

dyvim commented 4 years ago

Hello @Lockbox313 My french translation is almost finished but there is a term that I didn't manage to retrieve in the rules... What is the "MQ Mod."

Thanks for all your work to add the data-i18n tags.

I will close the issue just after your response I think.

dyvim commented 4 years ago

I've found that MQ was an abbreviation of Move quietly. I close this issue as all is resolved.