search

Roll20 / roll20-character-sheets

Character sheet templates created by the community for use in Roll20 VTT. Submit a ticket at roll20.net/help if critical hotfixes are to be requested.
https://roll20.net/
MIT License
1.16k stars 4.15k forks source link

Das_Schwarze_Auge_4-1 - PA_Aktiv no more calculated on new character #8717

Closed FKueng closed 3 years ago

FKueng commented 3 years ago

When creating a new character on the said sheet the value for PA_Aktiv is not calculated correctly. It still works on existing characters but not on new ones. Also cloned characters seem to be affected.

FKueng commented 3 years ago

It seems to be related to the wounds a character has taken. Having him take a wound and removing it again fixes the issue.

kreuvf commented 3 years ago

It seems to be related to the wounds a character has taken. Having him take a wound and removing it again fixes the issue.

Thanks for reporting this. These are some side effects of the ongoing efforts of switching to sheetworker scripts - it is a bug nonetheless. I have a hunch for the root cause and for the next new feature release I plan on adding more code to stabilize the sheet against such issues. Some attributes are only set via sheetworker scripts. On a new sheet, they do not exist yet and when trying to access them they will taint everything that relies on them.

Unfortunately, I know of no way to automatically test individual character sheets (unit tests), so finding bugs is a manual process.

(By releasing new stuff now and then, people will complain if stuff breaks I haven't found in my testing. Therefore, this kind of feedback is very valuable to me and all other players!)

Necrask commented 3 years ago

I'll just add that for existing characters, if you use the Trefferpunkte feature to determant damage I get the following error message in chat: Dmgroll

I think there may be a common cause.

kreuvf commented 3 years ago

I'll just add that for existing characters, if you use the Trefferpunkte feature to determant damage I get the following error message in chat: Dmgroll

I think there may be a common cause.

No, there is isn't, see: https://github.com/kreuvf/roll20-character-sheets/issues/69.

kreuvf commented 3 years ago

It seems to be related to the wounds a character has taken. Having him take a wound and removing it again fixes the issue.

The latest version/Pull Request (https://github.com/Roll20/roll20-character-sheets/commit/8ef92ddf209566383d85f19e447348c4c8cedf4c) should fix this. When version 20210425 is live (~tomorrow), please tell me whether the issue persists or not.

kreuvf commented 3 years ago

@mperes I forgot to add this issue to the commit message. As the PR just got accepted, this issue is fixed.

kreuvf commented 3 years ago

@FKueng: Please verify that this bug is gone and report this here. :)

FKueng commented 3 years ago

Thanks for fixing it @kluver