search

RolnickLab / ami-platform

GNU General Public License v3.0
8 stars 2 forks source link

[AMI-267] Enable collections to be defined & populated from UI #375

Closed mihow closed 2 months ago

mihow commented 3 months ago

image

image

Description TBD!

netlify[bot] commented 3 months ago

Deploy Preview for ami-web ready!

Name Link
Latest commit 9ace9c86277f85f1cc69a678bfe604683f3e609e
Latest deploy log https://app.netlify.com/sites/ami-web/deploys/6620aad8193ef300086c722f
Deploy Preview https://deploy-preview-375--ami-web.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 1 paths audited
Performance: 69
Accessibility: 95
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for ami-storybook ready!

Name Link
Latest commit 9ace9c86277f85f1cc69a678bfe604683f3e609e
Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/6620aad84ae84a000883cd3f
Deploy Preview https://deploy-preview-375--ami-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mihow commented 3 months ago

Hi @annavik! This started as a "simple" change so users can make and populate Collections in the UI, since that is a missing piece for the batch processing workflow. But it turned out to be my largest contribution to the UI code yet! And I had a lot of catching up to do. I know this could be cleaner, but I am hoping to compromise and make something available to demo soon. We should probably discuss more about collections. They may be outgrowing the sub-tab under project overview.

After this, I am definitely look forward to re-using the backend types in the frontend. I tested that using our autogenerated openAPI schema -> typscript and it worked amazingly well. I will make a PR with an example soon. Also I am curious about using react-hook-form library more directly. It seems like there are some layers of abstraction/simplification that could be skipped? It was difficult for me to find where values are being transformed before being passed to the server. Anyway, take a look if you have a chance, but no worries if we have to wait until June.