RolnickLab / ami-platform

GNU General Public License v3.0
8 stars 2 forks source link

Fix failing pre commit hook #396

Closed annavik closed 1 month ago

netlify[bot] commented 1 month ago

Deploy Preview for ami-web ready!

Name Link
Latest commit aa807028c656ec55c41767a2dbbd8160f1dd6027
Latest deploy log https://app.netlify.com/sites/ami-web/deploys/6667571e9fa4c10008d00bcb
Deploy Preview https://deploy-preview-396--ami-web.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 72
Accessibility: 95
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for ami-storybook ready!

Name Link
Latest commit aa807028c656ec55c41767a2dbbd8160f1dd6027
Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/6667571e5e2a8400089b213d
Deploy Preview https://deploy-preview-396--ami-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

annavik commented 1 month ago

@mihow think I need some help with the pre-commit hook here 🙏 it works fine for me when I trigger locally!

Or we can disable lint check from pre-commit hook until we have a solution?

mihow commented 1 month ago

@annavik I tried a few things and failed! But now it looks like there is a different package that is more popular for frontend/React projects to run linting on pre-push, called Husky

I am removing Eslint from the pre-commit hook for now