search

Romain / Matomo-IP-to-Company

A plugin for Matomo which gives you the name of the company that visited your website, based on its IP.
GNU General Public License v3.0
15 stars 11 forks source link

Update for Matomo 5 compatibility #38

Open snake14 opened 11 months ago

snake14 commented 11 months ago

Dear Matomo Plugin Author, We are excited that Matomo 5.0.0 is on the horizon, and we would greatly appreciate your assistance in ensuring that your plugin remains compatible with this upcoming release. Maintaining compatibility will enable Matomo users to seamlessly use your plugin after they upgrade to Matomo 5. (If the plugin is not updated to be compatible with Matomo 5, then whenever a user will upgrade to Matomo 5, the plugin would be automatically disabled to prevent issues.)

Updating your plugin to be Matomo 5 compatible is a straightforward process and should not require a significant time investment. You can find more information about updating your plugin at: https://developer.matomo.org/guides/migrate-matomo-4-to-5

Thank you for your ongoing support and commitment to the Matomo community. Your contribution is really appreciated!

The Matomo Team

PS: we’re also available to help if you have any question about making the plugin compatible.

snake14 commented 11 months ago

Hi @Romain . I took the liberty of forking this project and making the necessary changes. If you create a 5.x-dev branch, rebase this PR to that branch, merge the PR, and create a new release, you should be good to go. NOTE: The reason I advise creating a new 5.x-dev branch instead of merging into master is so that you can continue to maintain your plugin for older versions of Matomo.

eheu commented 11 months ago

From README

Requirements

Your Matomo version should be between 3.9.0 and below 4.0.0.

Does this PR address this limitation?

snake14 commented 11 months ago

From README

Requirements Your Matomo version should be between 3.9.0 and below 4.0.0.

Does this PR address this limitation?

Hi @eheu . I missed that in the readme. I'm not really sure why that restriction was mentioned. I addressed all of the compatibility issues I saw. It would be best to have someone familiar with the plugin to confirm that it works as expected with Matomo 5.