multiple changes - Githubissues

RomainLanz / adonis-bull-queue

Queue system based on BullMQ for AdonisJS

MIT License

147 stars 26 forks source link

multiple changes #15

Closed ikudosi closed 1 year ago

ikudosi commented 2 years ago

Proposing the following changes:

Update BullMQ version to latest
Allow queue:listen to pass multiple queues to listen (ex: queue:listen --queue:default,somethingelse)
Allow the native BullMQ jobs.attempts option to be respected. The handle method was encapsulated in a try/catch thus cannot honor retry.
Allow calling a failed() from the job class when max attempts has succeeded and function exists.

RomainLanz commented 2 years ago

Wow, thanks!

I need to add some tests to avoid manual testing. 😓 I will play a bit with your PR.

What do you think of adding more documentation inside the README file for people unfamiliar with Queues and BullMQ?

ikudosi commented 2 years ago

@RomainLanz did my best to add to the readme. This is honestly my first ever attempt at contributing to any repo so bare with me xD. Hopefully all goes well on your end!

RomainLanz commented 2 years ago

@RomainLanz did my best to add to the readme. This is honestly my first ever attempt at contributing to any repo so bare with me xD. Hopefully all goes well on your end!

No worries!

It seems that you aren't passing the Job instance when instantiating the requested job.

ikudosi commented 2 years ago

@RomainLanz adjusted the code so that the job instance is passed to the processor.

RomainLanz commented 1 year ago

Sorry for the delay, and thanks for the changes. I will have a look later today!

RomainLanz commented 1 year ago

Thanks! ❤️