Roman971
commented
4 years ago I haven't looked at the cosmetic plando code and all those changes yet, but I most likely will at some point. Like I mentioned in discord the other day, I think it would be better if I PR'd the new options first, which should get in without trouble hopefully, then you can PR the plando stuff and the rest, since I have no plan to do any other cosmetic changes for a while.
That thing about not breaking backwards compatibility with navi/sword trail patching sounds interesting but I'm not confident in my ability to cherry-pick that. If you think it's worth it and you can do it, I'm down to merge that on its own before making the PR to Dev. Tho I'm completely fine with just PRing my branch as is like I intended, and have your changes fix things up later, so it's up to you if you think it's worth.
This adds Cosmetic Plando, changing the cosmetic log into a .json and allowing you to use it to more finely tweak options that aren't exposed by the GUI (and those that are), allowing you to modify any color that would get its own random color, select sound effect options that aren't normally exposed as an option in the GUI, or plan out what music goes where.
Other changes from Dev include splitting the button color options back out to how they currently are on Dev-R (and how they used to be before they were consolidated) as GUI space isn't really a good reason to have them combined and have two versions of the same cosmetic function in the wild. Even with them expanded back out, the UI colors is even with equipment colors and shorter than misc colors, as we can see on Dev-R.
Changes from the new-cosmetics branch is mainly condensing some of the functions. As far as actual behavior goes, it now will allow Navi color patching (and sword trail color patching for that matter) when applying cosmetics to a patch file that doesn't support the rainbow options, falling back to "Completely Random" as a substitute for rainbow and putting an error letting the user know in the log.
I figured I'd just go ahead an open a PR here because I am not sure exactly how to handle getting this merged. Since we have both modified large sections of the same code, it was an annoying merge. I'm assuming the goal of this branch is eventually getting it merged into Dev, so this seems like the best course of action to take beyond waiting for that merge to happen before opening a PR for this.
Let me know what you think.