Entrance pools for setting plando'd entrances only include one side of overworld entrances as top level keys. This fails seed generation when the opposite direction is specified. The PR adds searches on the .reverse property of the primary entrances, then swaps variables as necessary to link the right entrances.
Tested on 50 random settings seeds with forced full mixed pools, another 50 random settings seeds with forced indoor-only mixed pools, and a final 50 with no mixed pools by generating a seed and feeding the spoiler back into the randomizer as a plando. Decoupled was tested with full mixed only for 50 random settings seeds. The only modifications to the plando are removing fixed shop items from locations, the item pool, and hints. The two attached plandos were used for development and testing:
There are some remaining issues with world validation that this PR does not address. This includes invalid starting area, ToD passing access as both ages, ToT access guarantee as opposite age, and Biggoron access (maybe any always-hinted location?). When these came up in testing, I verified that the plando had the same error in the unmodified branch.
Entrance pools for setting plando'd entrances only include one side of overworld entrances as top level keys. This fails seed generation when the opposite direction is specified. The PR adds searches on the .reverse property of the primary entrances, then swaps variables as necessary to link the right entrances.
Tested on 50 random settings seeds with forced full mixed pools, another 50 random settings seeds with forced indoor-only mixed pools, and a final 50 with no mixed pools by generating a seed and feeding the spoiler back into the randomizer as a plando. Decoupled was tested with full mixed only for 50 random settings seeds. The only modifications to the plando are removing fixed shop items from locations, the item pool, and hints. The two attached plandos were used for development and testing:
Full mixed, only OW ER on Full mixed, OW, All Indoor, Dungeon ER on
There are some remaining issues with world validation that this PR does not address. This includes invalid starting area, ToD passing access as both ages, ToT access guarantee as opposite age, and Biggoron access (maybe any always-hinted location?). When these came up in testing, I verified that the plando had the same error in the unmodified branch.