search

Roman971 / OoT-Randomizer

A randomizer for Ocarina of Time.
Other
96 stars 21 forks source link

Misinterpreted plando entrance #56

Open fenhl opened 3 years ago

fenhl commented 3 years ago

A plando like the following should either produce a potion shop whose exits are tied together (so that it's only reachable via a one-way connector), or give an error about that being impossible (as with this example, both because it doesn't have mixed pools to connect the entrances together and because it doesn't have a setting like warp song shuffle to make the shop reachable):

{
    "settings": {
        "shuffle_interior_entrances": "all"
    },
    "entrances": {
        "Kak Potion Shop Front -> Kakariko Village": "Kak Potion Shop Back"
    }
}

On TestRunner's fork, this plando generates an error message as expected. However, on this fork, it generates a seed with this in the spoiler log:

    "Kakariko Village -> Kak Potion Shop Front":            "Kak Potion Shop Back",
    "Kak Backyard -> Kak Potion Shop Back":                 "Kak Odd Medicine Building",
    "Kokiri Forest -> KF Midos House":                      "Kak Potion Shop Front",

The randomizer seems to be misinterpreting the entrance as its opposite, thus making the potion shop reachable from Kakariko.

Roman971 commented 3 years ago

Thanks for the bug report. I think this is most likely related to changes made in #53, which changed how plando interprets entrances to allow more possibilites in mixed pools plando (so it's not in TR's fork right now). @mracsys Do you think this could be related? And if so, would you have an idea on how to fix it? I can look into myself ofc, but I might not have time to for a while.

mracsys commented 3 years ago

53 only swapped overworld entrance direction if I remember correctly. The same system should be able to be applied to interiors/grottos/dungeons if the OW type filter is removed, with the same limitations on keeping the forward/reverse pools even or fully specifying the world in plando.

No idea why it currently does what it does at first glance.

Roman971 commented 3 years ago

Looking at the diff, I think some of the changes might have affected more than just overworld entrances, especially the part about matched_targets_to_region, but I might be misreading it.